~rogpeppe/juju-core/azure

[r=jtv] Unify providers' user-data composition functions.

All the "physical" providers (EC2, OpenStack, MAAS, Azure) were generating
user data in essentially the same way. The MAAS one looked different but
actually just added an optional bit that was still completely generic. And so
this branch unifies the implementations.

Construction of the cloudinit.MachineConfig was lifted out of the function.
That may seem arbitrary, but it's part of a greater plan: in a later step of
the ongoing refactoring the construction can be lifted out of the providers'
internalStartInstance methods as well, doing away with the EC2 and OpenStack
providers' startInstanceParams structs. This actually shortens some of the
data flows and reduces cognitive load, which can only be good for maintenance.

After that step we can have a fresh look at sanitizing NewMachineConfig (which
arguably should take more parameters, or not exist at all, but is in an
intermediate state that facilitates the changes happening now). We may also
look into re-introducing some sort of dedicated Parameter Object for
internalStartInstance, but by then the cluster of methods Bootstrap /
StartInstance / internalStartInstance will look a bit different and we can
find the most maintainable solution for that new situation.
Filename Latest Rev Last Changed Committer Comment Size
..
agent 1409.2.2 10 years ago John Arbash Meinel Turn environs/agent into a top level agent/ packag Diff
bzr 1104.1.1 11 years ago Gustavo Niemeyer bzr: add package to handle Bazaar branches Diff
cert 734.5.14 11 years ago Roger Peppe add cert package Diff
charm 11 12 years ago Gustavo Niemeyer Applied the juju/charm renaming to the Go code bas Diff
cloudinit 25.2.1 12 years ago Roger Peppe add cloudinit package Diff
cmd 37.3.14 12 years ago William Reade hefty rearrangement, few actual changes Diff
constraints 1010.3.1 11 years ago Benji York checkpoint: tests pass; major refactoring to avoid Diff
container 1263.2.25 10 years ago Tim Penhey Merge prev pipe. Diff
doc 773.7.1 11 years ago William Reade added some draft documentation Diff
downloader 358.2.4 11 years ago Roger Peppe downloader: first test passes Diff
environs 25.5.4 12 years ago Roger Peppe rename environ->environs Diff
errors 1242.1.1 10 years ago Ian Booth Move common errors to erros package and remove dup Diff
instance 1274.1.3 10 years ago Tim Penhey Move environs.Instance into its own package. Diff
juju 37.3.14 12 years ago William Reade hefty rearrangement, few actual changes Diff
log 20.1.1 12 years ago Mathieu Lonjaret logger: use global vars, becomes a package Diff
rpc 766.2.1 11 years ago Roger Peppe rpc: initial commit Diff
schema 1 12 years ago Gustavo Niemeyer Bootstrapped package. Diff
scripts 980.1.1 11 years ago Dave Cheney renamed contrib to scripts Diff
state 525.1.1 11 years ago Roger Peppe mstate: rename to state Diff
store 882.1.5 11 years ago John Arbash Meinel Merge trunk resolve series parameter conflict. Diff
testing 83.1.2 12 years ago William Reade renamed testutils; broke it in anticipation of goz Diff
thirdparty 623.3.1 11 years ago Roger Peppe environs: add PasswordHash and RandomBytes Diff
upstart 152.5.1 11 years ago William Reade first cut, untested Diff
utils 1151.1.1 11 years ago Tim Penhey Trivial rename of trivial -> utils. Diff
version 124.2.2 11 years ago Roger Peppe version: simplify Diff
worker 295.1.1 11 years ago Dave Cheney service => worker Diff
.bzrignore 936.1.2 11 years ago Brad Crittenden Added emacs desktop files to bzrignore 141 bytes Diff Download File
.lbox 269.4.7 11 years ago William Reade whoops: readd .lbox 30 bytes Diff Download File
File .lbox.check 1278.2.2 10 years ago Danilo Šegan Move emacs auto-save files check to find command i 590 bytes Diff Download File
CONTRIBUTING 1408.1.1 10 years ago John Arbash Meinel Start changing the imports of the middle level fil 7.1 KB Diff Download File
LICENCE 703.1.1 11 years ago Dave Cheney + LICENCE 33.7 KB Diff Download File
Makefile 1253.2.3 10 years ago Jeroen Vermeulen Review change: MongoDB must be 'installed,' not 'r 810 bytes Diff Download File
README 1253.2.2 10 years ago Jeroen Vermeulen Don't install MongoDB immediately, but add a notic 5.2 KB Diff Download File