Viewing all changes in revision 3051.
- Committer: Daniel van Vugt
- Date: 2012-03-12 07:38:02 UTC
- mfrom: (3041.1.3 arg-work)
- Revision ID: daniel.van.vugt@canonical.com-20120312073802-rc9x9j6ldhpxnb9l
CompIcon had some design errors:
/1/ it contained two copies of CompSize (a member and a base);
/2/ it allowed non-const use of base CompSize member functions (which breaks
invariants);
/3/ it could be copied/assigned leading to double-delete of mData; and,
/4/ it could be "sliced" leading to leak of mData.
None of the core code did any of 2-4, but they'll no longer compile.
/1/ it contained two copies of CompSize (a member and a base);
/2/ it allowed non-const use of base CompSize member functions (which breaks
invariants);
/3/ it could be copied/assigned leading to double-delete of mData; and,
/4/ it could be "sliced" leading to leak of mData.
None of the core code did any of 2-4, but they'll no longer compile.
- files modified:
- include/core/abiversion.h
expand all
collapse all
added
removed
