~smspillaz/folly/folly-git-master : changes

~smspillaz/folly/folly-git-master » Changes from revision 8696

From Revision 8696 to 8677

Rev	Summary	Authors	Date
8696	fix buffer overrun fix buffer overrun Summary: (Note: this ignores all push blocking failures!) Reviewed By: andriigrynenko Differential Revision: D23005233 fbshipit-source-id: 4ea528505e06fec0af7841ccbd6d41eabe0de558	Misha Shneerson	3 years ago
8695	Make //folly/tracing/test:static_tracepoint_test work if com... Make //folly/tracing/test:static_tracepoint_test work if compiled as PIE. Summary: A tracepoint semaphore address is written to the notes section as either the absolute address (if binary is compiled as non-PIE) or the relative address (if binary is compiled as PIE) of the semaphore. In the former case, the test passes; in the latter case, the test as it was could not possibly pass because the binary is mapped to some random base address. This diff makes a guess: if the addresses are equal, then we're non-PIE; otherwise check if the address offset is valid - that offset is the address at which the binary is mapped, so it always begins with the ELF header, so we can check against that. If someone knows how to easily figure out that random address or to detect whether the binary is PIE (thereby disabling the test) that'd be great too. This fixes TSAN for the test, as TSAN binaries are built as PIE. Reviewed By: yfeldblum Differential Revision: D22752824 fbshipit-source-id: cd320f9fb8355a20f65e2385f0a1ab1c24ec0b81	Robin Cheng	3 years ago
8694	Fix OpenSSLUtils::getCommonName to correctly trim trailing n... Fix OpenSSLUtils::getCommonName to correctly trim trailing null characters Summary: Previously `OpenSSLUtils::getCommonName` was allocating a 64 byte long string and copying the common name from the `X509` into it. We unexpectedly returned that string potentially containing trailing `\0`s. This diff rewrites the function to allocate a big enough buffer, write to it, then return an appropriately trimmed new string from it. Reviewed By: yfeldblum Differential Revision: D22910431 fbshipit-source-id: 77b4fc3ccde4f7ddb0f62b884ecd7ff0c868c1ca	Sotirios Delimanolis	3 years ago
8693	make time based unit-test less flaky by waiting longer make time based unit-test less flaky by waiting longer Reviewed By: yfeldblum, andriigrynenko Differential Revision: D22965140 fbshipit-source-id: 8f9996ccc28aff621879774e901b0c75e8c62883	TJ Yin	3 years ago
8692	hazptr: Make cohort active_ data-race-free hazptr: Make cohort active_ data-race-free Summary: Make hazptr_obj_cohort active_ atomic to be data-race-free. Reviewed By: yfeldblum Differential Revision: D22976574 fbshipit-source-id: 5a09aa7cedc26c71b2160b2df14a7e0f7b55e2e7	Maged Michael	3 years ago
8691	folly/README: Update the Fedora deps in the public README folly/README: Update the Fedora deps in the public README Summary: The deps for Fedora in the public README are a little out of date. Add / update some. Reviewed By: yfeldblum Differential Revision: D22951514 fbshipit-source-id: 645af3df1b71dcdab06408d73d99c34c482ea534	Paul Jakma	3 years ago
8690	Fix fiber backtraces in gdb Fix fiber backtraces in gdb Summary: When we do the context switch onto the fiber, the stack frame points back to the main context stack. While the fiber is running, this allows backtraces to continue back onto the main context. When the fiber is suspended, we execute code on the main context's stack, the pointers to this stack are now garbage, backtracing in gdb runs into problems, such as garbage frames, gdb crashes, and occasional cycles. The fix here is to write a 0 to the saved return address in the last frame, when a fiber suspends. gdb detects this and stops the trace #38 folly::fibers::FiberManager::activateFiber(folly::fibers::Fiber) (this=0x0, fiber=0x0) at folly/fibers/FiberManagerInternal-inl.h:82 #39 folly::fibers::FiberManager::runReadyFiber(folly::fibers::Fiber) (this=0x0, fiber=0x0) at folly/fibers/FiberManagerInternal-inl.h:127 #40 0x0000000000000000 in () I gated the fix to linux since I'm not sure about the ABI for other platforms. Reviewed By: yfeldblum Differential Revision: D22774189 fbshipit-source-id: 2d4ad67a4a01bebc4ff1f9c285f6e3e95d13432c	Chris Keeline	3 years ago
8689	Update zstd dev debian package Update zstd dev debian package Summary: - Move to the newer and forward moving libzstd-dev https://packages.ubuntu.com/search?suite=default&section=all&arch=any&keywords=libzstd&searchon=names Reviewed By: wez Differential Revision: D22981784 fbshipit-source-id: 3647357aad60f2335ea494c35c174e9ffec61346	Cooper Lees	3 years ago
8688	Fix an atomic memory ordering issue in SIMD version of the C... Fix an atomic memory ordering issue in SIMD version of the ConcurrentHashMap. Summary: The find path reads a node that the insert path writes; they need to have acquire/release semantics due to the node being allocated on the fly. Reviewed By: yfeldblum, magedm Differential Revision: D22937394 fbshipit-source-id: c1497ed1764cd43e396bc520e9b716cdfe29e5ca	Robin Cheng	3 years ago
8687	runcmd: do not pipe stdout on a tty runcmd: do not pipe stdout on a tty Summary: Redirecting stdout means that ninja/cmake won't act as if it's invoked interactively, ie: it will buffer the output, show every single files being compiled (instead of just a line or progress), etc. This results in a fairly janky UX when getdeps is used on the command line. By not redirecting stdout, we get immediate feedback about the tests being run, and the files being compiled. Reviewed By: wez Differential Revision: D22967815 fbshipit-source-id: 872ddbf421065686c384a3a876d0acb8832baf2e	Xavier Deguillard	3 years ago
8686	Prefer std::condition_t vs preprocessor in AsyncSocket Prefer std::condition_t vs preprocessor in AsyncSocket Summary: [Folly] Prefer `std::condition_t` vs preprocessor in `AsyncSocket`. Reviewed By: bschlinker, lnicco Differential Revision: D22975614 fbshipit-source-id: 562d1b794ec3dbab538ad507b2ec5d0fe07c7757	Yedidya Feldblum	3 years ago
8685	Let exceptionStr peek into unknown exception types Let exceptionStr peek into unknown exception types Summary: [Folly] Let `exceptionStr` peek into unknown exception types when building with libstdc++ via `std::exception_ptr::__cxa_exception_type()`. Reviewed By: ot, luciang Differential Revision: D22521812 fbshipit-source-id: b75811ed4159df81e651c5df1386c406f6ac6d60	Yedidya Feldblum	3 years ago
8684	Add yield_value(Try<>) to coro::Task Add yield_value(Try<>) to coro::Task Summary: Generic code taking in a `Task<void\|T>` cannot easily forward the result without throwing exceptions because the `return_value` overload taking a `Try` cannot be added to `Task<void>` which already has `return_void`. Instead we use `yield_value` as we did with `co_error` to make the desired generic code possible. Reviewed By: lewissbaker Differential Revision: D22934887 fbshipit-source-id: ec50de5832f9038d92749bdde2c1d43244288a3c	Shai Szulanski	3 years ago
8683	pre-allocate freeList pre-allocate freeList Summary: We know ahead of time the size of this list, so may as well pre-allocate space for it Reviewed By: yfeldblum Differential Revision: D22838412 fbshipit-source-id: 7d70495fe0910e65dfea49fe7baf675308ab9331	Dylan Yudaken	3 years ago
8682	Make folly/experimental/symbolizer/test:elf_tests work if co... Make folly/experimental/symbolizer/test:elf_tests work if compiled as PIE. Summary: If the binary is compiled as PIE, such as in the case of TSAN, the kStringValue symbol's value, which is an address that in turn points to the "coconuts" character array, may be stored as 0 in the binary file, and rely on the dynamic linker to relocate at loading time. The corresponding relocation entry (in the .rela.dyn section) contains the relative offset instead. We do not seem to have implemented parsing of the relocation section, so this diff changes the test to be more lenient, and upon seeing a zero will just verify the address of the symbol against the live binary. Reviewed By: yfeldblum Differential Revision: D22782080 fbshipit-source-id: ffbfc7c23b84865fb29bbfb782feb896d687594b	Robin Cheng	3 years ago
8681	Add the ability to set the event EventRecvmsgCallback Add the ability to set the event EventRecvmsgCallback Summary: Add the ability to set the event EventRecvmsgCallback Reviewed By: danobi Differential Revision: D22959687 fbshipit-source-id: 274cecf4ab4b8015d5e7e725c7e899f603cea7a0	Dan Melnic	3 years ago
8680	Add missing include in folly/ExceptionString.cpp Add missing include in folly/ExceptionString.cpp Summary: [Folly] Add missing include in `folly/ExceptionString.cpp`. Reviewed By: ot, luciang Differential Revision: D22529764 fbshipit-source-id: 91af74023fd81b1882a19889fd92fda4e1bdfcc7	Yedidya Feldblum	3 years ago
8679	Fix TSAN issues with FibersTest. Fix TSAN issues with FibersTest. Summary: Two issues: - Executor not properly shutdown before destruction - Shadow stack overflow due to TSAN not handling fibers correctly. For this we just reduce the number of tasks for now; the proper fix would be likely quite involved and it's not clear whether it's worth it at this point since I think it only affects diagnostic messages that TSAN prints. Reviewed By: yfeldblum Differential Revision: D22901657 fbshipit-source-id: 833454e6f54ab6fc7c53333157197345e8d887e2	Robin Cheng	3 years ago
8678	Add option to build with ASAN on OSS build Add option to build with ASAN on OSS build Summary: Environment variable WITH_ASAN can be set to enable building with ASAN options. Ran into issues with getdeps.py extensions P137131160. Once that is resolved will do away with the ENV approach Requires building folly lib also with ASAN to avoid linking issues Reviewed By: shri-khare Differential Revision: D22860508 fbshipit-source-id: 48dea49378319972894f69b11bac6fa63ee20db9	Ravindra Sunkad	3 years ago
8677	remove unneeded spinlock remove unneeded spinlock Summary: This spin lock is not required, and guards quite a complex region that could easily fallback to the slow path Reviewed By: andriigrynenko Differential Revision: D22839268 fbshipit-source-id: 045a3562a2d4358b4c95e155a4b9958b2b7f67d4	Dylan Yudaken	3 years ago

Older »