~smspillaz/folly/folly-git-master : changes

~smspillaz/folly/folly-git-master » Changes from revision 9855

From Revision 8986 to 8967

Rev	Summary	Authors	Date
8986	Use AtomicNotificationQueue in EventBase Use AtomicNotificationQueue in EventBase Differential Revision: D24414496 fbshipit-source-id: ad552d3dd58b6c351c99e5f8c9056c5829c4c095	Andrii Grynenko	3 years ago
8985	Add a StringPiece formatter Add a StringPiece formatter Summary: Add an {fmt} formatter for `StringPiece`. This is much faster than going through ostream `operator<<` which we fallback to otherwise. Reviewed By: yfeldblum Differential Revision: D24337424 fbshipit-source-id: c6f1775cf83cfa6bcaa25cb4f6b665a76672e7c3	Victor Zverovich	3 years ago
8984	clean up unnecessary c++ extern imports clean up unnecessary c++ extern imports Summary: A lot of these imports with specialization is not necessary. Clean up them to use generic functions instead. (Note: this ignores all push blocking failures!) Reviewed By: yfeldblum Differential Revision: D24236181 fbshipit-source-id: fe6e6c41f680561c625b263bc6adeba738ddb252	Nanshu Chen	3 years ago
8983	Invoke life cycle observer callbacks during event base attac... Invoke life cycle observer callbacks during event base attach and Summary: Inform LifecycleObservers when an EventBase is attached or detached from an AsyncSocket. Reviewed By: bschlinker Differential Revision: D24294292 fbshipit-source-id: 652ec438d0b6213a78742b8a8ef0d24d55ac9816	Sridhar Srinivasan	3 years ago
8982	Implement ReadMostlyTLObserver Implement ReadMostlyTLObserver Summary: Implement a thread local Observer that optimizes on the shared_ptr copy by using ReadMostlySharedPtr Reviewed By: andriigrynenko Differential Revision: D24439652 fbshipit-source-id: 9174be7f3f2fc34bdc79bd83eab571972b0c057d	Margot Leibold	3 years ago
8981	constructor benchmark constructor benchmark Summary: Construction of ReadMostlyMainPtr is much slower than shared_ptr Reviewed By: yfeldblum Differential Revision: D24350176 fbshipit-source-id: 55730192f79288e7ad848b4cec6483bc0c1711b6	Margot Leibold	3 years ago
8980	AtomicNotificationQueue AtomicNotificationQueue Summary: This is a lock-free replacement for NotificationQueue. Unlike notification queue it supports only one consumer, which allows simplifying the internal structure a lot and avoiding any use of spin locks. Another improvement comparing to NotificationQueue is the use of epoll edge-triggered events. This allows completely eliminating read syscals, since we don't need to drain eventfd to stop it from waking up the epoll loop. Differential Revision: D24297158 fbshipit-source-id: 1f418d861210f6dcad52b4d663f49eb2e8f3ae8c	Andrii Grynenko	3 years ago
8979	encode PACKAGE_VERSION in libfolly.pc encode PACKAGE_VERSION in libfolly.pc Summary: `libfolly.pc` should contain the actual version of Folly, instead of just `master`. Reviewed By: danobi Differential Revision: D24471074 fbshipit-source-id: 5fc29eeee25c8c317c3405f430fd079d47c441bd	Michel Salim	3 years ago
8978	Fix EventBase death tests Fix EventBase death tests Summary: Existing test was supposed to be testing the exception, but was instead dying because of the pid check. Have 2 separate tests and use crash message regex to make sure they actually test what they are supposed to be testing. Differential Revision: D24461683 fbshipit-source-id: b7ef30e488d266ea17e283f9b13b5d013a4a125a	Andrii Grynenko	3 years ago
8977	folly: set shared libraries version folly: set shared libraries version Summary: This should make packaging folly easier, as it allows one to set the .so version to denote ABI breaks. Specifically, we're looking to use this in https://bugzilla.redhat.com/show_bug.cgi?id=1887621 to package folly in Fedora and have the version match the tagged release version (i.e. treat every release as ABI breaking). Differential Revision: D24451669 fbshipit-source-id: f63be760c90567117f1ebbec37416c0d9d8a4736	Davide Cavalca	3 years ago
8976	folly: always enable PIE in shared libs build folly: always enable PIE in shared libs build Summary: This reverts https://github.com/facebook/folly/pull/833 by adding back the unconditional setting of `POSITION_INDEPENDENT_CODE` when building shared libs. Without it, the build fails with a number of relocation errors. This was previously reported in https://github.com/facebook/folly/issues/983 Differential Revision: D24449731 fbshipit-source-id: 6f6cb71ef545d02998afb09909772b62657c1262	Davide Cavalca	3 years ago
8975	folly: fix permissions on a couple of files folly: fix permissions on a couple of files Summary: These do not need to be executable Differential Revision: D24449732 fbshipit-source-id: 5f013c62dd6bf88fe4d50782a4c5bfcec6834aec	Davide Cavalca	3 years ago
8974	`FOLLY_MAYBE_UNUSED` does not work on Windows `FOLLY_MAYBE_UNUSED` does not work on Windows Summary: `frame` may be unused depending on whether it is compiled with or without asserts. `FOLLY_MAYBE_UNUSED` is supposed to take care of this, but it does not work on Windows and trips up the comiler: ``` warning C4100: frame: unreferenced formal parameter ``` Reviewed By: johnkearney, akrieger Differential Revision: D24451220 fbshipit-source-id: 8225640a5e8fd0ceed4ffcc53cea7422a5581d6f	Michael Lee (Enginee...	3 years ago
8973	to_shared_ptr_aliasing to_shared_ptr_aliasing Summary: [Folly] `to_shared_ptr_aliasing`, exposing the shared-ptr aliasing constructor as a free function deducing the types of its arguments. Reviewed By: Mizuchi Differential Revision: D24414504 fbshipit-source-id: 290e822464860b824961986211375d87f942f483	Yedidya Feldblum	3 years ago
8972	Update folly::fibers to preserve thread_local AsyncStackRoot Update folly::fibers to preserve thread_local AsyncStackRoot Summary: Updates the FiberManager to make sure that it saves/restores the current-thread's top-most active AsyncStackRoot when the coroutine is suspended/resumed. This is required for correctness to ensure async stack traces remain functional in the presence of fiber context-switches. (Note: this ignores all push blocking failures!) Reviewed By: yfeldblum Differential Revision: D21130668 fbshipit-source-id: 4002bae0fc12a61c38836f9f099da4e6cf9183f4	Lewis Baker	3 years ago
8971	Fix UndefinedBehaviorSanitizer error in `retryingPolicyCappe... Fix UndefinedBehaviorSanitizer error in `retryingPolicyCappedJitteredExponentialBackoff` Summary: While running some unit tests which happen to call into `folly::futures::retryingPolicyCappedJitteredExponentialBackoff`, I noticed that `retryingJitteredExponentialBackoffDur` was triggering a "float-cast-overflow" error from UndefinedBehaviorSanitizer. It turns out that this only happened if `backoff_min` was 0 and there were at least 1025 retries. The large retry count caused the exponential term in the calculation to become `Infinity`. In floating point, Infinity multiplied by 0 was `NaN`, causing the sanitizer error. Although `backoff_min` should typically not be set to 0 because this effectively disables all backoff, I think there may be cases, such as unit tests, where setting `backoff_min` to 0 does make sense. This commit adds an additional check to handle this unusual case. Reviewed By: yfeldblum Differential Revision: D24122470 fbshipit-source-id: 48a8aede0d22e73cf001dab5eb184e841f3c23aa	Alex Blanck	3 years ago
8970	Remove FOLLY_HAVE_MSG_ERRQUEUE check Remove FOLLY_HAVE_MSG_ERRQUEUE check Summary: Remove FOLLY_HAVE_MSG_ERRQUEUE check Reviewed By: yfeldblum Differential Revision: D24295244 fbshipit-source-id: 24d4a69a013951b37fe7c93539b26eedf8113360	Dan Melnic	3 years ago
8969	Use assert() instead of DCHECK Use assert() instead of DCHECK Summary: We were seeing the following build failures on i386: ``` In file included from folly/stats/detail/BufferedStat.h:151, from folly/stats/QuantileEstimator.h:20, from folly/stats/QuantileEstimator.cpp:17: folly/stats/detail/BufferedStat-inl.h: In member function 'void folly::detail::BufferedStat<DigestT, ClockT>::doUpdate(folly::detail::BufferedStat<DigestT, ClockT>::TimePoint, const std::unique_lock<folly::SharedMutexImpl<false> >&, folly::detail::BufferedStat<DigestT, ClockT>::UpdateMode)': folly/stats/detail/BufferedStat-inl.h:72:3: error: there are no arguments to 'DCHECK' that depend on a template parameter, so a declaration of 'DCHECK' must be available [-fpermissive] 72 \| DCHECK(g.owns_lock()); \| ^~~~~~ ``` My best guess is some kind of argument dependent lookup complication. This diff sidesteps the issue by using plain old `assert()` instead Reviewed By: yfeldblum Differential Revision: D24375147 fbshipit-source-id: d702d883fcabc548e8f4969207e265abf21acf2b	Daniel Xu	3 years ago
8968	AsyncUDPSocket: use actual controllen size instead of max AsyncUDPSocket: use actual controllen size instead of max Summary: AsyncUDPSocket: use actual controllen size instead of max Reviewed By: danobi Differential Revision: D24368739 fbshipit-source-id: 0c1083a058d8fe0ddc212989a262f3eeebfa610c	Dan Melnic	3 years ago
8967	rust/shed/hostname: rename hostname dependency to unbreak do... rust/shed/hostname: rename hostname dependency to unbreak doctests (#15) Summary: Pull Request resolved: https://github.com/facebookexperimental/rust-shed/pull/15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: https://github.com/rust-lang/cargo/issues/6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406	Lukas Piatkowski	3 years ago