~smspillaz/folly/folly-git-master : changes

~smspillaz/folly/folly-git-master » Changes from revision 9855

From Revision 9840 to 9821

Rev	Summary	Authors	Date
9840	Back out "Don't use typeid without RTTI in UniqueInstance" Back out "Don't use typeid without RTTI in UniqueInstance" Reviewed By: prajay Differential Revision: D29673416 fbshipit-source-id: f08fa89db74198aa648e871837f1f7b841cd8d6b	Pranjal Raihan	2 years ago
9839	Back out "RequestContext::StaticContextAccessor" Back out "RequestContext::StaticContextAccessor" Reviewed By: mshneer Differential Revision: D29673244 fbshipit-source-id: 62676c498a60c720d463703f5f1e24b421683a85	Pranjal Raihan	2 years ago
9838	RequestContext::StaticContextAccessor RequestContext::StaticContextAccessor Summary: Redo of D29536635 (https://github.com/facebook/folly/commit/bc0818f89e7ab3802cdac95a25e29f4061021c3c) but rebased on top of `UniqueInstance.h` fixes. Reviewed By: yfeldblum Differential Revision: D29630206 fbshipit-source-id: ed103849edd6edd3f9c4ef75368c2fa1b038182b	Pranjal Raihan	2 years ago
9837	Don't use typeid without RTTI in UniqueInstance Don't use typeid without RTTI in UniqueInstance Summary: The class depends on RTTI. It's a sanity check that crashes if two instances of a singleton are created. So doing nothing in `-fno-rtti` code is fine. Reviewed By: yfeldblum Differential Revision: D29630207 fbshipit-source-id: 4976f72394086afe12e224e40fe955636108e713	Pranjal Raihan	2 years ago
9836	a test for memcpy-use a test for memcpy-use Summary: Proves the internal build rule replaces `memcpy`. Reviewed By: LoganEvans Differential Revision: D29665797 fbshipit-source-id: 7f3a8550853261de94cedf9545b6445d11297b2b	Yedidya Feldblum	2 years ago
9835	Daily `arc lint --take BLACK` Daily `arc lint --take BLACK` Reviewed By: zertosh Differential Revision: D29656934 fbshipit-source-id: c40bbc8e4512b145050ee47db2c8dc781f3c36e9	CodemodService Bot	2 years ago
9834	Move FindZstd.cmake into fbcode_builder Move FindZstd.cmake into fbcode_builder Summary: A bunch of existing projects vendor it into their own CMake folder. But these same projects also have fbcode_builder's CMake directory in their CMAKE_MODULE_PATH, so move FindZstd here. Differential Revision: D29637686 fbshipit-source-id: 805676e18f98ef217dea8511d039edc38771b529	Mingtao Yang	2 years ago
9833	Mark zstd as a dependency of fizz Mark zstd as a dependency of fizz Summary: I don't understand why we have both manifests/specs; I was assuming one was generated from the other, but I don't see a at-generated and grep doesn't show up anything, so both are manual edits. Reviewed By: iahs Differential Revision: D29524000 fbshipit-source-id: 5f6df62f0162ea24a9903bedf5d220eab5c2dff1	Fred Emmott	2 years ago
9832	Opt in opensource/fbcode_builder to pyfmt Opt in opensource/fbcode_builder to pyfmt Reviewed By: zertosh Differential Revision: D29612107 fbshipit-source-id: ac450058134e23a3831db35d2e49c80eb8cde36a	Zsolt Dollenstein	2 years ago
9831	Revert D29536635: RequestContext::StaticContextAccessor Revert D29536635: RequestContext::StaticContextAccessor Differential Revision: D29536635 (https://github.com/facebook/folly/commit/bc0818f89e7ab3802cdac95a25e29f4061021c3c) Original commit changeset: 008a612ec65a fbshipit-source-id: 2c18348732f1b1f8022e3cc8dce5a5684ce16108	Dong Li	2 years ago
9830	fix flaky test fix flaky test Summary: AsyncSocketSendmmsgIntegrationTest.PingPongRequest fails during stress runs with multiple jobs due to the 5ms timeout in `UDPClient::sendPing()`. Increasing the timeout fixes the issue. Reviewed By: yfeldblum Differential Revision: D29623870 fbshipit-source-id: ad6ee0356001fbded9ce01ddc099b708d1477899	Tim Berning	2 years ago
9829	RequestContext::StaticContextAccessor RequestContext::StaticContextAccessor Summary: `RequestContext::StaticContextAccessor` acts as a guard, preventing all threads with a `StaticContext` from being destroyed (or created). Reviewed By: yfeldblum Differential Revision: D29536635 fbshipit-source-id: 008a612ec65aa7095450f4d0ab522e8ecd864548	Pranjal Raihan	2 years ago
9828	Optimize small_vector copy and move for inline storage Optimize small_vector copy and move for inline storage Summary: Codegen for copy and move assignment is suboptimal when the vectors involved are inline, in particular if the destination is default-constructed (which is very common) and even more so if the value type is trivially copyable. The main optimization is that if the storage is inline and the type is trivially-copyable, we can just copy the whole storage, regardless of the size of the container. This avoids a branchy loop, and it's usually just a handful of MOVs. While at it, optimized all the related code paths by avoiding delegating to `swap()` and `assign()` when possible, which introduce further branches that are hard to optimize. Also move and copy in place when the vector is non-empty, avoiding unnecessary destructions. Also fixed a couple of bugs: - The move constructor did not clear its argument when inline, inconsistently with the move assignment and `std::vector` - The move assignment operator passed its heap storage to the argument instead of freeing it. Reviewed By: yfeldblum Differential Revision: D29592519 fbshipit-source-id: 6281cdda775568d28619afea8b7ca2fb168c7e5d	Giuseppe Ottaviano	2 years ago
9827	cut Tearable cut Tearable Summary: It is unused. An upcoming Concurrency TS will have a replacement. Reviewed By: mshneer Differential Revision: D29597486 fbshipit-source-id: a108b945ce32eb17cedefad89630c9171fc5c9c2	Yedidya Feldblum	2 years ago
9826	Make `travis_docker_build.sh` macos-compatible Make `travis_docker_build.sh` macos-compatible Summary: BSD readlink doesn't have -f. I'm not using TravisCI, however docker is still convenient for reproducing builds locally. Reviewed By: yns88 Differential Revision: D29523333 fbshipit-source-id: e01169f3eabca7b8baec95bc70fe119cad201b35	Fred Emmott	2 years ago
9825	Implement contains() in sorted vector types Implement contains() in sorted vector types Summary: Implement C++20 `contains()`. Reviewed By: yfeldblum Differential Revision: D29556436 fbshipit-source-id: 1c3a8e6e9a07f6e47491b063f88df6bf9da2d87b	Giuseppe Ottaviano	2 years ago
9824	Make ThreadLocalPtr::Accessor::Iterator default construct as... Make ThreadLocalPtr::Accessor::Iterator default construct as singular Reviewed By: yfeldblum, mshneer Differential Revision: D29578762 fbshipit-source-id: 2aa9af8f68825997db8b71fc97dda5477fa57413	Pranjal Raihan	2 years ago
9823	Make folly::detail::IteratorAdaptor default-constructible Make folly::detail::IteratorAdaptor default-constructible Summary: [Forward iterators are required to be default constructible](https://en.cppreference.com/w/cpp/named_req/ForwardIterator). So as of today, `IteratorAdaptor` is lying! We should default construct the wrapped iterator into a [singular iterator](https://eel.is/c++draft/iterator.requirements#general-7): > Iterators can also have singular values that are not associated with any sequence. Results of most expressions are undefined for singular values; the only exceptions are destroying an iterator that holds a singular value, the assignment of a non-singular value to an iterator that holds a singular value, and, for iterators that meet the `Cpp17DefaultConstructible` requirements, using a value-initialized iterator as the source of a copy or move operation. Reviewed By: yfeldblum, mshneer Differential Revision: D29578765 fbshipit-source-id: 7f2f0762b17f0b1a056532fc5db2abdd76cca3ea	Pranjal Raihan	2 years ago
9822	Make RequestContext::StaticContext an aggregate struct inste... Make RequestContext::StaticContext an aggregate struct instead of std::pair Summary: Let's give them better names than `first` and `second`. Reviewed By: yfeldblum, mshneer Differential Revision: D29536636 fbshipit-source-id: bbb37f2e1c0c51dd1ce2a0cfeca85399f409c415	Pranjal Raihan	2 years ago
9821	Fix waiters signaling in BatchSemaphore Fix waiters signaling in BatchSemaphore Summary: Fix BatchSemaphore to post baton for a multiple waiter in a list as long as there are token available. Reviewed By: yfeldblum Differential Revision: D29430799 fbshipit-source-id: 98b0a616d0ce863108dcf331e491fd2cc12429d1	Sergey Korytnikov	2 years ago

Older »