Viewing all changes in revision 5702.
- Committer: Facebook Github Bot
- Date: 2018-07-20 21:23:20 UTC
- Revision ID: git-v1:20eea8f085f733626d442a762bb100563f90b5e0
Revert Folly NestedRequestContextGuard
Summary:
This attempted to provide a deep copy guard for folly request context.
Per brainstorming (see task), we don't think that deep copying all metadata has legitimate use cases. And in fact, this has no usage in our codebase currently. Because it default to reset (when createChild is not overriden), the behaviour is also very confusing.
Guards's goal is usually to copy 1 metadata. The solution for that is to provide a shallow copy guard. Something that I will do on top of this revert.
I'll wait for both changes to be discussed and accepted before landing this one.
Reviewed By: yfeldblum, LeeHowes
Differential Revision: D8906912
fbshipit-source-id: e8b9eed04cbe539009037ff75d51e28941502d88
Summary:
This attempted to provide a deep copy guard for folly request context.
Per brainstorming (see task), we don't think that deep copying all metadata has legitimate use cases. And in fact, this has no usage in our codebase currently. Because it default to reset (when createChild is not overriden), the behaviour is also very confusing.
Guards's goal is usually to copy 1 metadata. The solution for that is to provide a shallow copy guard. Something that I will do on top of this revert.
I'll wait for both changes to be discussed and accepted before landing this one.
Reviewed By: yfeldblum, LeeHowes
Differential Revision: D8906912
fbshipit-source-id: e8b9eed04cbe539009037ff75d51e28941502d88
expand all
collapse all
added
removed
