~smspillaz/folly/folly-git-master

Viewing all changes in revision 6821.

  • Committer: Facebook Github Bot
  • Author(s): Rob Sherwood
  • Date: 2019-03-20 01:30:03 UTC
  • Revision ID: git-v1:5357c1171ea5a3b1ceb5f9d87181cb9e66e69670
Tweak the OSS gflags dependency inference logic

Summary:
The current logic for "which gflags library should we use" checks for
the first library (e.g., libgflags vs. libgflags-shared) listed as a TARGET.
Unfortunately, on some number of systems, the gflags-config.cmake (read:
the file that is supposed to tell you how to use gflags with cmake) actually
defines (but doesn't use!) libraries that don't exist (!) so this logic breaks.

Instead, use the system defined gflags_LIBRARIES variable which explicitly
tells us which library to use.

Reviewed By: yfeldblum, simpkins

Differential Revision: D14512966

fbshipit-source-id: add4ecf6bade502b2d12aad2bdfcf0476eeba465

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: