~smspillaz/folly/folly-git-master

Viewing all changes in revision 8710.

  • Committer: Facebook GitHub Bot
  • Author(s): Nathan Bronson
  • Date: 2020-08-12 07:13:22 UTC
  • Revision ID: git-v1:efe2962d54734d9e899f592dfaa68055e7752858
fix forwarding for hinted insert_or_assign

Summary:
The hinted forms of insert_or_assign were forwarding with
std::move rather than std::forward, which has the potential to elevate
a non-const lvalue ref to an rvalue ref.

(Note: this ignores all push blocking failures!)

Reviewed By: yfeldblum

Differential Revision: D21475865

fbshipit-source-id: e91e759762cf6f045c843cd7de1402953e6afb61

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: