~soren/nova/doc-build-dir

Viewing all changes in revision 807.

  • Committer: Tarmac
  • Author(s): Brian Lamar
  • Date: 2011-03-15 19:01:27 UTC
  • mfrom: (790.1.2 lp732866)
  • Revision ID: tarmac-20110315190127-fn1q4fso98wx6mbp
Fixed lp732866 by catching relevant `exception.NotFound` exception. Tests did not uncover this vulnerability due to "incorrect" FakeAuthManager. I say "incorrect" because potentially different implementations (LDAP or Database driven) of AuthManager might return different errors from `get_user_from_access_key`.

Also, removed all references to 'bacon', 'ham', 'herp', and 'derp' and replaced them with hopefully more helpful terms.

Long story short it addresses the immediate issue while throughly ignoring the larger issue, which is correctly testing all implementations of Auth. I find this acceptable as currently the future of auth is in flux. 

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: