~squid/squid/qa-tests

Viewing all changes in revision 14876.

  • Committer: Alex Rousskov
  • Date: 2016-10-06 22:05:50 UTC
  • Revision ID: rousskov@measurement-factory.com-20161006220550-hne7crvcbbbf05bs
Fix known "concurrent c_str()s" violations of SBuf API.

The second c_str() call destroys the buffer still being used by the
first c_str() result, leading to many "Invalid read of size N" errors.

IMO, we must instead fix SBuf to make similar violations unlikely, but
there is currently no squid-dev consensus on whether and how to do that.
See "[RFC] Support concurrent SBuf::c_str() calls" thread on squid-dev.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: