-
Committer:
Thiago Bellini
-
Date:
2011-11-05 16:46:12 UTC
-
Revision ID:
hackedbellini@gmail.com-20111105164612-7iagywvhla0fxz7c
Correct 2 test methods names.
* test_runtime had a 'setDown' method. It wasn't really necessary as 'setUp'
has it's logic in it. That's why it didn't interfered in nothing on test,
since the right name for it would be 'tearDown'. Just removing it.
* TestReport's 'setUp' logic was written on 'tearUp'. For that reason, it
wasn't being called and the workaround it tried to apply wasn't working (I
didn't noticed it when I wrote the patch because I had no cache at the
moment, and jenkins never fail on that test). Rename it and everything should
be fine!
Maybe we should try to create a pattern on tests. Use 'setUp/setDown' or
'tearUp/tearDown' (I think the second makes more sense) to avoid problems like
that, that happened for distraction and the assumption of a pattern.