~super-friends/friends/13.10 : changes

~super-friends/friends/13.10 » Changes from revision 235

From Revision 21 to 2

Rev	Summary	Authors	Date
21	Add a new gsettings schema, with a basic subset of options. Add a new gsettings schema, with a basic subset of options. I reviewed the old gwibber gschema and identified just a few options that we are actually using at this point (most of the other options are holdovers from when gwibber still had it's own frontend). Also modified setup.py to install it for us.	Robert Bruce Park	12 years ago
20	Fix some AccountManager methods. Fixes lp:1069509 Fix some AccountManager methods. Fixes lp:1069509 Ok, so I reviewed this in much more depth than previously. This commit: * Unifies the behavior of disabling and deleting accounts. Now, if you're in UOA, and you flick an account to 'OFF', it's messages will be removed from the model. Similarly, if you outright delete an account, the associated messages are also deleted. Currently we do not make any distinction between a "disabled" and a "deleted" account. In both cases, messages are removed from the model, and no attempts are made to redownload messages from that account, until it is re-enabled later. * Removes the "refresh callback" from the AccountManager, because that was stupid. It turns out, when an account is enabled, you only need to call 'receive' on that one account, not on all of them together. So this is a nice little efficiency win. * Updates all the tests to the new API changes. I tested this thoroughly with friends-service.sh, using UOA to enable, disable, delete, and recreate accounts, and it works great. The best part is, thanks to my previous work on using Model.insert_sorted instead of Model.append, deleting and re-adding messages to the model doesn't change the order of those messages in the Model.	Robert Bruce Park	12 years ago
19	SharedModel persistence has landed! SharedModel persistence has landed!	Robert Bruce Park	12 years ago
18	Implement Dispatcher.SendReply, with tests. Implement Dispatcher.SendReply, with tests. This was requested by kenvandine, who discovered that Dispatcher.Do was inadequate for this purpose.	Robert Bruce Park	12 years ago
17	Add a test case for the Dispatcher. Add a test case for the Dispatcher.	Robert Bruce Park	12 years ago
16	Fix Flickr's timestamps. Fix Flickr's timestamps. This was another case of the mocks not matching reality, so the test suite would pass, but in reality the timestamps weren't working. So I've updated the mocks to reflect reality, and updated the behavior to work correctly. This is confirmed to be working with debug_live.py.	Robert Bruce Park	12 years ago
15	Workaround for Authentication.login hanging, which was also ... Workaround for Authentication.login hanging, which was also causing Dispatcher.Refresh to hang thanks to it's use of thread.join(). Authentication.login was using an extraneous GObject MainLoop for the purposes of blocking it's thread synchronously until an async callback got called, but that was a dain bramaged approach because not only does it interfere with the primary mainloop, but Signon.AuthSession.process seems to have a bug where the callback often won't be called, causing the mainloop to block forever. I've replaced this mainloop with a while loop that calls time.sleep() a limited number of times. The advantage here is that we have direct control over how many times time.sleep() gets called and never have to worry about waiting for a callback that might never come to unblock us. This commit also makes sweeping changes to the logging infrastructure, which were necessary to track down this bug, and generally beneficial, so they're being included rather than reverted. Logging is now more verbose, and makes extensive use of the "logging.getLogger(__name__)" idiom for finer-grained data on which log is coming from where. debug_live.py also received an overhaul in order to better accommodate testing.	Robert Bruce Park	12 years ago
14	fixed traceback in the log output from enabling account. fixed traceback in the log output from enabling account.	Ken VanDine	12 years ago
13	merge trunk merge trunk	Barry Warsaw	12 years ago
12	More distutils nonsense. More distutils nonsense.	Barry Warsaw	12 years ago
11	Oops! Ad the file that handles installation. Oops! Ad the file that handles installation.	Barry Warsaw	12 years ago
10	Refactoring for package installation. Refactoring for package installation. * We need a distutils command in order to install the actual service files from the templates. * Re-use the bulk of the service file installation code for the test suite. * Make the check for the availability of the dbus-daemon executable earlier, and instead of raising a RuntimeError if it's missing, just say that the dbus tests can't be run (this is for the buildds).	Barry Warsaw	12 years ago
9	Merge lp:~ken-vandine/friends/dbus_services but with several... Merge lp:~ken-vandine/friends/dbus_services but with several changes: * Reuse (after moving) the existing service.in files, so we don't have duplication between the files used for testing and the actual installed service files. * Don't use the top-level data/ directory or the MANIFEST.in. * Don't use data_files key in setup()	Barry Warsaw	12 years ago
8	Merge lp:~ken-vandine/friends/unsupported_handling which all... Merge lp:~ken-vandine/friends/unsupported_handling which allows AccountManager.add_new_account() to log and ignore UnsupportedProtocolErrors. This is necessary because of the packaging requirement that protocols be installable by separate binary packages. This means, if friends-service-twitter (or the moral equivalent) is not installed, the user may still have a Twitter account enabled, but there will be no friends-service available for Twitter. This raises an UnsupportedProtocolError, but that's fine, and to be expected. I had to fix a couple of other things along the way: * Allow LogMock to work as a context manager (i.e. in a `with` statement). Use it this way if you want to narrow down the capturing of log messages. * Convert a few uses of LogMock from setUp()s to with-statements. * Instead of setting the mock logger level at NOTSET, set it to the value 1. NOTSET==0, but this propagates log messages to the root logger, even if propagate=False, so it's not quite what we want to do. Unfortunately, this also meant the log mocks are now capturing more output, but that's fine, I adjusted the appropriate tests. * Fix test_account_manager_add_new_account_unsupported() to capture and check the log messages. This proved that the test wasn't actually testing what it thought it was testing. Now fixed. * Fixed add_new_account() to narrow down the try/except clause.	Barry Warsaw	12 years ago
7	Merge lp:~robru/friends/count - with a few minor cleanups (p... Merge lp:~robru/friends/count - with a few minor cleanups (pyflakes warnings, etc.)	Barry Warsaw	12 years ago
6	* Add a wrapper script for easier in-source execution. (LP:... * Add a wrapper script for easier in-source execution. (LP: #1067005) * Add to README.rst information about the virtualenv. (LP: #1067002) * Fix a crash in --list-protocols	Barry Warsaw	12 years ago
5	Merge lp:~robru/friends/account-delete-fixup. Merge lp:~robru/friends/account-delete-fixup.	Barry Warsaw	12 years ago
4	Post-merge cleanup. Post-merge cleanup. * ReST-ify the README and give it an Emacs-friendly suffix. * Spell-checked and reformatted.	Barry Warsaw	12 years ago
3	Cleaned up AUTHORS and README Cleaned up AUTHORS and README	Robert Bruce Park	12 years ago
2	Stop dumping all possible messages into 'messages' stream. Stop dumping all possible messages into 'messages' stream. This commit introduces the 'private' stream, as well as unique 'search/*' streams that get created for every new search. This allows the model to be filtered by the stream column, in such a way that it's possible to show search results separately from the rest of the messages (previously, if you performed a search, there would be no way to distinguish search results from any other message in the 'messages' stream).	Robert Bruce Park	12 years ago