~themue/juju-core/037-empty-strings-in-charm-config : changes

~themue/juju-core/037-empty-strings-in-charm-config » Changes from revision 1572

From Revision 1572 to 1553

Rev	Summary	Authors	Date
1572	charm: allowing empty strings as valid config value for stri... charm: allowing empty strings as valid config value for string types	Frank Mueller	10 years ago
1571	cmd/set: corrected the reset of an invalid change to be exac... cmd/set: corrected the reset of an invalid change to be exact like before	Frank Mueller	10 years ago
1570	cmd/set: merged trunk cmd/set: merged trunk	Frank Mueller	10 years ago
1569	cmd/set: removed setting to empty string until clearance cmd/set: removed setting to empty string until clearance	Frank Mueller	10 years ago
1568	cmd/set: add option --default to set to default value cmd/set: add option --default to set to default value	Frank Mueller	10 years ago
1567	[r=jtv] Simplestreams query for Azure. [r=jtv] Simplestreams query for Azure. This adds to Azure the ability to query simplestreams for suitable OS images. It's not hooked up into combined instance-type and image selection; that's for a later branch. Testing this was tough. It's very hard to figure out why this isn't working when it isn't — all you get is an empty list of matches. I would have done more unit-testing, but I'm exhausted. There's also a little drive-by cleanup: the base test suite for Azure created an Environ for tests to use. This is bad practice, but luckily no tests were making use of it. I removed it before anyone gets it into their heads to make use of the thing.	jtv at canonical	10 years ago
1566	[r=sidnei],[bug=1205112] Escape dollar and dot in and out of... [r=sidnei],[bug=1205112] Escape dollar and dot in and out of MongoDB Both dollar sign and dot are not allowed as keys. In fact, dot creates a sub-document of some sort, which breaks compatibility with pyjuju and causes a panic (LP:1205112). The developer manual suggests escaping those with their unicode full width equivalents: http://docs.mongodb.org/manual/faq/developers/#faq-dollar-sign-escaping	Sidnei da Silva	10 years ago
1565	[r=dimitern] names: New package [r=dimitern] names: New package This introduces a new juju-core/names pacakge, which contains all name and tag related functions shared between state and API: IsUnitName, UnitTag, UnitNameFromTag, MachineTag, MachineIdFromTag, IsServiceName, etc. Because of the pacakge name, some functions were renamed: names.IsUnit, IsService, UnitFromTag, all refer to names. In addition, a change was made to these two functions: UnitNameFromTag and MachineIdFromTag. Both of them now return (string, error), rather than just string. The error return is used in case the passed tag string has an invalid format. Because of this change, some places needed slight refactoring, otherwise no other changes where made. https://codereview.appspot.com/12034043/ R=fwereade, rogpeppe	Dimiter Naydenov	10 years ago
1564	[r=rogpeppe] various: fix test races [r=rogpeppe] various: fix test races These are various places that rely on testing.ShortWait to wait for something to occur. I discovered them by setting testing.ShortWait to 1us and seeing what failed. https://codereview.appspot.com/11723043/	Roger Peppe	10 years ago
1563	[r=fwereade] state: unexport ParseTag [r=fwereade] state: unexport ParseTag ...which should clearly never have been exported in the first place. https://codereview.appspot.com/12097043/	William Reade	10 years ago
1562	[r=fwereade],[bug=1199886] jujuc: relation-set compatibility [r=fwereade],[bug=1199886] jujuc: relation-set compatibility lp:1199886 (relation-set should accept 0 args) https://codereview.appspot.com/11808045/	William Reade	10 years ago
1561	[r=themue] cmd/bootstrap: integrate syncing [r=themue] cmd/bootstrap: integrate syncing After the CL moving the synchronization logic into an own package this CL now checks if tools can be found during bootstrap. If this is not possible it will use the synchronization logic and then retries the bootstrapping. https://codereview.appspot.com/11910043/	Frank Mueller	10 years ago
1560	[r=julian-edwards] The Azure provider now creates/destroys i... [r=julian-edwards] The Azure provider now creates/destroys its own storage containers, removing the need to configure one.	Julian Edwards	10 years ago
1559	[r=rogpeppe] state/api/agent: new package [r=rogpeppe] state/api/agent: new package This provides functionality for the machine agent and unit agent. The old MachineAgent API entry point is now deprecated; the client entry point has been removed but the server side remains around until we can remove it (for backward compatibility with 1.12). https://codereview.appspot.com/12038045/	Roger Peppe	10 years ago
1558	[r=axwalk],[bug=1182898] cmd: Add --version to cmd.SuperComm... [r=axwalk],[bug=1182898] cmd: Add --version to cmd.SuperCommand There's no option to control the format; the sub-command must be used for that. https://codereview.appspot.com/11808044/	Andrew Wilkins	10 years ago
1557	[r=rvb] Azure provider: return a signed URL in the storage's... [r=rvb] Azure provider: return a signed URL in the storage's URL() method. This branch changes the implementation of the URL() method in storage.go so that it returns a "signed" URL that can be anonymously accessed. This allows uploading the tools to a private container while still allowing the machines to fetch the tools anonymously.	Raphael Badin	10 years ago
1556	[r=rogpeppe] worker/upgrader: ChangeAgentTools [r=rogpeppe] worker/upgrader: ChangeAgentTools Copy over from cmd/jujud before we delete it from there. https://codereview.appspot.com/12025043/	Roger Peppe	10 years ago
1555	[r=axwalk],[bug=1186969] cmd/juju: add help-tool subcommand [r=axwalk],[bug=1186969] cmd/juju: add help-tool subcommand This change introduces a new subommand to juju: juju help-tool: list all tools a la "help commands" juju help-tool <tool>: show tool's help https://codereview.appspot.com/11758043/	Andrew Wilkins	10 years ago
1554	[r=jtv] Standardize storage-consistency polling strategy. [r=jtv] Standardize storage-consistency polling strategy. All providers have a "shortAttempt" polling strategy, which they use both to wait for eventual storage consistency and for generally retrying things that may take a while to become possible. These package-global variables were getting in the way of the factoring-out of common code. And so, as discussed in https://codereview.appspot.com/11633043/ this branch makes the how-to-wait-for-storage-consistency part available on the StorageReader interface. VerifyBootstrapInit no longer needs to take the strategy as an argument, because it's available on the environment's storage object. Some shortAttempt variables are replaced entirely; in other cases we now have to different polling strategies that probably deserve to be tuned for their specific purposes. In agreement with Roger Peppe, I also documented an important property of AttemptStrategy that we weren't previously sure of: every attempt will perform at least once, so there's no need to build in special timings to ensure that behaviour in tests. Where providers need storage polling that actually sleeps, I made sure they override these with non-delaying strategies. For the providers with immediately-consistent storage there is no delay at all, and so no need to override the strategy either.	jtv at canonical	10 years ago
1553	[r=jtv] Outline Azure's simplestream parameters. [r=jtv] Outline Azure's simplestream parameters. We plan to substitute richer implementations here, but the first thing is to get basic simplestreams working. The methods added here provide the parameters which the Azure provider needs to pass to the imagemetadata package. Some of the tests for the later functionality were really simple, and they help demonstrate the intent of the existing API, so I added them now, watched them fail as expected, but then commented them out instead of implementing the functionality.	jtv at canonical	10 years ago

Older »