-
Committer:
William Reade
-
Author(s):
William Reade
-
Date:
2012-10-04 23:59:53 UTC
-
mfrom:
(599.5.13 juju-core)
-
Revision ID:
fwereade@gmail.com-20121004235953-e5kuxcol09np5fow
uniter: integrate filter type
By tweaking the filter slightly, to provide more carefully-tailored events,
the uniter Modes have been radically simplified.
Note that state.Unit was previously mis-specified, and is now fixed: it's
fine (in fact, potentially necessary) to resolve errors when the unit is
Dying.
Also note that there are roughly 50% more full Uniter tests than the
previous branch, but they run in roughly the same amount of time. Win!
But! This is actually a significant slowdown, because I fixed a bunch of
happy-path 500ms waits in the uniter tests. It's true that this variant does
more unnecessary work in the service of simpler Mode code, and I haven't been
able to find any obvious hotspots (apart from the pre-existing one) so if
reviewers would bear subtle performance implications in mind I would be most
grateful :).
R=rog, niemeyer
CC=
https://codereview.appspot.com/6588053