~thopiekar/emgd/xserver-xorg-input-synaptics-github_community

Viewing all changes in revision 1303.

  • Committer: Peter Hutterer
  • Date: 2013-04-26 00:18:48 UTC
  • Revision ID: git-v1:8fcc413285d347ecb6a27e0761ef4ce6fd56ca0a
Fix stack smash in clickpad_guess_clickfingers()

Apple Magic Trackpad can report 16 slots. In clickpad_guess_clickfingers()
the array allocated on the stack contains only 10 slots.
As (.num_mt_mask == .num_slots), the function writes out of the bounds
of close_point.

Use a size 32 bitmask instead and warn if we ever get past 32 touchpoints.

This fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=952221

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reported-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Conflicts:
        src/synaptics.c

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: