-
Committer:
Tarmac
-
Author(s):
Free Ekanayaka
-
Date:
2013-04-23 13:50:29 UTC
-
mfrom:
(660.2.3 amp-cleanup-2)
-
Revision ID:
tarmac-20130423135029-plhso0kausu3xp7u
Merge amp-cleanup-2 [f=1170669] [r=ack,tealeg] [a=Free Ekanayaka]
This branch is a step toward the goal of fully-synchronous tests in the client. In detail:
- Drop the retry_on_reconnect parameter of the RemoteBroker constructor, and
stick it to MethodCallClientFactory instead. The idea is to make the factory
a sort of controller of RemoteBroker. Since user code is supposed to deal
with factories directly, the can control the RemoteBroker's behavior by
modifying the factory.
- Move the MethodCallFactory class after the RemoteBroker class, since we now need
to set the latter as 'remote' class attribute of the former.
- Rename MethodCallFactory to MethodCallClientFactory, since this is really
a protocol factory for clients, not for servers.
- Implement a new interface for MethodCallClientFactory, which should be more convenient
for user-code. This includes adding a getRemoteObject method and replacing the
notify_success and notify_failure methods with a single notifyOnConnect (camel case
for consistency with Twisted).