~ubuntu-branches/ubuntu/oneiric/seahorse/oneiric-proposed-201111150713

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
If you want to hack or commit something to seahorse, please first send patches to 
seahorse-list@gnome.org or submitted on bugzilla.gnome.org if possible.

For a todo list, first check bugzilla, then look at TODO. Bugzilla is also updated 
with possible enhancements and any current bugs.

Here is a description of the modules:

 o daemon: Various background servers and processes run in this daemon including
   the gpg agent, dbus server, etc...
 
 o data: Data files that need to be processed. Current this is just schemas. They 
   are here because there will be multiple schemas files to separate the app and 
   pgp settings.

 o libseahorse: Common static library of code for seahorse. Any code that is depended 
   on by multiple modules, such as src/ and plugins/nautilus, is placed here. 
   Currently this includes SeahorseContext & keys, operations, and common dialogs.

 o src: The key manager program. This currently includes the main window & dialogs.


USING THE GPG EXECUTABLE DIRECTLY

Unless absolutely necessary seahorse limits itself to using the functionality 
found in the GPGME library. This is to prevent maintenance, versioning, syntax
and regression problems that arise from parsing the gpg executable output 
directly. 

In some cases the GPGME doesn't have a given feature that is necessary for 
Seahorse's operation. This may be due to the GPGME developers not having 
implemented that feature yet, or refusal to implement a given feature. In 
these cases direct use of GPG is permitted. Such cases must be documented 
below, and must be discussed before hand on the seahorse-devel mailing list.

 o seahorse-agent implements a gpg-agent compatible assuan interface. It also
   depends on figuring out where the GPG home directory is and modifying 
   GPG options (see below).
   - agent/*
   
 o The Backup Keyrings feature accesses the ~/.gnupg/pubring.gpg and 
   ~/.gnupg/secring.gpg files directly. 
   - src/seahorse-key-manager.c
   
 o There is code which modifies the ~/.gnupg/gpg.conf GPG configuration file. 
   - libseahorse/seahorse-gpg-options.c
   
 o Photo ID support
   - gpgme_op_edit state machine in libseahorse/seahorse-pgp-key-op.c 
   
 o Export Secret Key Support 
   - libseahorse/seahorse-gpgmex.c


DEBUGGING SEAHORSE

There are a couple of configure switches that you can enable which add
debugging helpers etc...

--enable-debug 
    - Disables optimization
    - Debug info
    - Enables various checks and logging in the code.
    - Makes all Gtk|Glib etc... runtime warnings fatal.
    - Makes all compilation warnings fatal.
    
--enable-fatal-messages
    When used with --enable-debug turns on fatal compile and runtime warnings.

INDENTATION STYLE

  * No gratituous reformatting of code. If you're rewriting much of a function 
    or file it's okay to reformat it, but reformatting for the sake of it isn't 
    a good idea.

    static int 
    function (int x, const char *y) 
    {
        if (func (arg, arg2 + 1, lots, of, very, lengthy, arguments, for 
                  this, function)) {
                  
            switch (val) {
            case XXX:
                break;
            case YYY:
                break;
            default:
                break;
            }
        } else {
            y = y * x + 1;
        }
        
        return func2 (x, y);
    }

  * For consistency we expand tabs into spaces. This means no tabs in files
    unless there's a specific reason for it.
  * Break long lines where possible.
  * Spaces between functions and arguments, or macros and arguments.
  * Spaces before and after most binary operators. 
  * Spaces after most unary operators (including a comma).
  * Brace on same line as block statement. 
  * Single lined block statements don't need braces unless it makes things 
    significantly clearer. 
  * Return value on line before function definition.
  * Brace on line after function definition.
  * '*' goes with variable not type, when declaring a pointer.
  * Function arguments follow the function call on the same line, and if 
    lengthy are (where possible) wrapped to the column of the first brace.
 
last updated 2010-01-26