1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
//
// AccessToDisposedClosureIssue.cs
//
// Author:
// Mansheng Yang <lightyang0@gmail.com>
//
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System.Collections.Generic;
using System.Linq;
using ICSharpCode.NRefactory.CSharp.Analysis;
using ICSharpCode.NRefactory.TypeSystem;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
//[IssueDescription ("Access to disposed closure variable",
// Description = "Access to closure variable from anonymous method when the variable is" +
// " disposed externally",
// Category = IssueCategories.CodeQualityIssues,
// Severity = Severity.Warning,
// IssueMarker = IssueMarker.Underline,
// ResharperDisableKeyword = "AccessToDisposedClosure")]
public class AccessToDisposedClosureIssue : AccessToClosureIssue
{
public AccessToDisposedClosureIssue ()
: base ("Access to disposed closure")
{
}
protected override bool IsTargetVariable (IVariable variable)
{
return variable.Type.GetAllBaseTypeDefinitions ().Any (t => t.KnownTypeCode == KnownTypeCode.IDisposable);
}
protected override NodeKind GetNodeKind (AstNode node)
{
if (node.Parent is UsingStatement)
return NodeKind.ReferenceAndModification;
if (node.Parent is VariableDeclarationStatement && node.Parent.Parent is UsingStatement)
return NodeKind.Modification;
var memberRef = node.Parent as MemberReferenceExpression;
if (memberRef != null && memberRef.Parent is InvocationExpression && memberRef.MemberName == "Dispose")
return NodeKind.ReferenceAndModification;
return NodeKind.Reference;
}
protected override bool CanReachModification (ControlFlowNode node, Statement start,
IDictionary<Statement, IList<Node>> modifications)
{
if (base.CanReachModification (node, start, modifications))
return true;
if (node.NextStatement != start) {
var usingStatement = node.PreviousStatement as UsingStatement;
if (usingStatement != null) {
if (modifications.ContainsKey(usingStatement))
return true;
if (usingStatement.ResourceAcquisition is Statement &&
modifications.ContainsKey ((Statement)usingStatement.ResourceAcquisition))
return true;
}
}
return false;
}
protected override IEnumerable<CodeAction> GetFixes (BaseRefactoringContext context, Node env,
string variableName)
{
yield break;
}
}
}
|