~ubuntu-branches/ubuntu/utopic/qmenumodel/utopic-proposed

Viewing changes to libqmenumodel/src/qstateaction.cpp

Committer: Package Import Robot
Author(s): Ubuntu daily release, CI bot, Albert Astals, Ubuntu daily release
Date: 2014-03-05 06:54:32 UTC
mfrom: (1.1.15)
Revision ID: package-import@ubuntu.com-20140305065432-em58pldlccvpttzl

Tags: 0.2.7+14.04.20140305-0ubuntu1

[ CI bot ]
* No change rebuild against Qt 5.2.1.

[ Albert Astals ]
* Fix use of un-initialized memory Since m_valid was not initialized
  calling setValid ends up in an uninitialized memory use in the if
  comparison. The other thing setValid does is emitting a signal, but
  this is the constructor, so you don't need the signal either, so
  basically just assign the variable directly .

[ Ubuntu daily release ]
* New rebuild forced

files modified:
debian/changelog

libqmenumodel/src/qstateaction.cpp

Show diffs side-by-side

added added

removed removed

libqmenumodel/src/qstateaction.cpp

bool isValid = m_group->hasAction(name);

setValid(isValid);

if (isValid) {

m_valid = m_group->hasAction(name);

if (m_valid) {

setState(m_group->actionState(name));

}

Older »