49
|
|
[cjwatson, r=gmason] Use archive.getPublishedSources(order_by_date=True) for a significant speedup.
The query that extract-changelogs is currently relying on is very slow, and there are some subtle ways in which iterating over the collection can go wrong. For ddeb-retriever, we did a fair bit of work on this:
https://bugs.launchpad.net/launchpad/+bug/1441729 https://code.launchpad.net/~cjwatson/launchpad/db-index-bpph-datecreated/+merge/255539 https://code.launchpad.net/~cjwatson/launchpad/getpublishedbinaries-sorting/+merge/255822
In the case of extract-changelogs, it should be sufficient to add order_by_date=True, which has the effect of joining fewer tables and using a reasonably well-indexed query to return a collection which is in decreasing ID order. If the collection changes during iteration (as long as you don't try to do any status filtering or similar, as explained in a comment here) then the worst case is that you get the same source package more than once, but extract-changelogs already handles this in LaunchpadChangelogsCrawler._unpack_changelogs_to_target.
Please do test this! I have not done so. However, I hear that extract-changelogs times out when asked to work from a very old starting date, and this should make it behave a lot better.
Review:
moon127 ran this successfully. After discussion, it looks safe to merge this with IS superpowers.
|
Greg Mason |
7 years ago
|
|
|
48
|
|
|
Brian Murray |
8 years ago
|
|
|
47
|
|
|
Brian Murray |
8 years ago
|
|
|
46
|
|
|
Brian Murray |
8 years ago
|
|
|
45
|
|
|
Brian Murray |
8 years ago
|
|
|
44
|
|
|
Stéphane Graber |
10 years ago
|
|
|
43
|
|
|
Stéphane Graber |
10 years ago
|
|
|
42
|
|
|
Stéphane Graber |
10 years ago
|
|
|
41
|
|
|
Stéphane Graber |
10 years ago
|
|
|
40
|
|
|
Michael Vogt |
12 years ago
|
|
|
39
|
|
|
Michael Vogt |
12 years ago
|
|
|
38
|
|
|
Michael Vogt |
12 years ago
|
|
|
37
|
|
|
Michael Vogt |
12 years ago
|
|
|
36
|
|
|
Michael Vogt |
12 years ago
|
|
|
35
|
|
|
Michael Vogt |
13 years ago
|
|
|
34
|
|
|
Michael Vogt |
13 years ago
|
|
|
33
|
|
|
Michael Vogt |
13 years ago
|
|
|
32
|
|
|
Michael Vogt |
13 years ago
|
|
|
31
|
|
|
Michael Vogt |
13 years ago
|
|
|
30
|
|
|
Michael Vogt |
13 years ago
|
|
|