~ubuntuone-hackers/django-modeldict/trunk : changes

~ubuntuone-hackers/django-modeldict/trunk » Changes from revision 70

From Revision 70 to 51

Rev	Summary	Authors	Tags	Date
70	update README to include related Disqus project update README to include related Disqus project	Kalail		8 years ago
69	Merge pull request #9 from YPlan/yplan_notice Merge pull request #9 from YPlan/yplan_notice Add deprecation notice to point to the YPlan fork	Kalail		8 years ago
68	1.4.1 1.4.1	David Cramer	1.4.1	11 years ago
67	Ship 1.4.0 Ship 1.4.0	Jeff Pollard	1.4.0	11 years ago
66	Attempt to appease the dependency gods Attempt to appease the dependency gods	Jeff Pollard		11 years ago
65	Fix bug that caused us to pull down things every time Fix bug that caused us to pull down things every time Summary: So there was a bug in modeldict that caused the entire switch set to be pulled from cache any time `_cleanup()` was called on the modeldict, which happened every time the `request_finished` and `task_postrun` signals were fired. This was bad, as it means we have a cache `get()` calls to pull down the heavy switch set every single page load and celery task. The bug happened because `_cleanup()` reset the `_last_checked_for_remote_changes` variable to `None`, effectively clobbering any information that the modeldict had to know what it's own personal `last_modified` timestamp was. Thus, it had no way to know if the remote cache had changed given its version. Practically, it caused this line of code to be run: ``` return int(cache_last_updated) > self._last_checked_for_remote_changes ``` `cache_last_updated` was the timestamp of the `last_updated` value in remote cache (when the switch set last changed), and `self._last_checked_for_remote_changes` was `None`, reset by `_cleanup()`. No matter what valid `cache_last_updated` value there is, comparing `any_value > None` is always `True`, so the modeldict thought that remote had changes and it pulled them down. The change was to add a separate `_local_last_updated` instance variable that actually tracked the cached `last_updated` value. This leaves `_last_checked_for_remote_changes` to only be used to track when the modeldict last synced its local cache with the remote one, and to be reset without blowing away the locally cached `last_updated` value. Test Plan: Existing tests, plus I added another test that asserts when cleanup is called it does not `get()` the whole switch set from the cache. Reviewers: dcramer, ted Reviewed By: dcramer Differential Revision: http://phabricator.local.disqus.net/D4150	Jeff Pollard		11 years ago
64	Refactor base.py to be a little easier to follow. Refactor base.py to be a little easier to follow. Summary: My brain was exploding with all the terminology (cache, local_cache, _cache, etc), so I refactored the variable names and whatnot to be a little more semantic. NOTE: this does not fix the cache hit performance regression, but this was a dependency on it to make the logic actually read and make sense. Test Plan: existing Reviewers: dcramer Reviewed By: dcramer Differential Revision: http://phabricator.local.disqus.net/D4132	Jeff Pollard		11 years ago
63	Add .arcconfig Add .arcconfig	Jeff Pollard		11 years ago
62	1.3.6 1.3.6	David Cramer	1.3.6	11 years ago
61	Correct _cleanup comment Correct _cleanup comment	David Cramer		11 years ago
60	Comments Comments	David Cramer		11 years ago
59	Comments Comments	David Cramer		11 years ago
58	Never hit last_updated_cache_key if self._cache was not set Never hit last_updated_cache_key if self._cache was not set	David Cramer		11 years ago
57	rename test to be more appropriate rename test to be more appropriate	David Cramer		11 years ago
56	Ensure when last_updated_cache_key is missing we re-set if w... Ensure when last_updated_cache_key is missing we re-set if we were successfully able to pull from the cache	David Cramer		11 years ago
55	Explicit False value on is_local_expired Explicit False value on is_local_expired	David Cramer		11 years ago
54	We only should reset last_updated_cache_key when the cache i... We only should reset last_updated_cache_key when the cache is pushed to	David Cramer		11 years ago
53	Clean up logic to prevent excessive calls to the main cache ... Clean up logic to prevent excessive calls to the main cache key when there is already a local cache	David Cramer		11 years ago
52	Ensure get_default still conforms to the instances option in... Ensure get_default still conforms to the instances option in ModelDict	David Cramer	1.3.5	11 years ago
51	Test correction and additions Test correction and additions	David Cramer	1.3.4	11 years ago

Older »