-
Committer:
GitHub
-
Author(s):
bmbouter
-
Date:
2017-06-20 13:10:11 UTC
-
Revision ID:
git-v1:09bd23bbd83344b09cbf38b7257107e560db9f25
Adds `multiple` kwarg to Qpid `Channel.basic_ack` (#755)
Celery 4.0.2 passes the `multiple` keyword argument to `basic_ack`.
This did not used to occur with 3.1.20- so this change is only being
merged into the 4.0 branch. The desired functionality of this param is
documented here [0], but the Qpid transport uses UUIDs as the
delivery_tags so we don't have a record of the sequential messages
required to implement this. We use UUIDs as the deliver_tag to avoid
Issue #563.
With the functionality for the `multiple` parameter not implemented, an
AssertionError is raised if Celery attempts to meaningfully use the
`multiple` parameter with the Qpid transport. A developer or user who
encounters this AssertionError should file a bug with Kombu.
[0] http://amqp.readthedocs.io/en/latest/reference/amqp.connection.html#amqp.connection.Connection.Channel.basic_ack
closes #699