- Committer: Sam Spilsbury
- Date: 2011-04-30 13:35:17 UTC
- Revision ID: git-v1:8655885ced663539527f0b7aaa701bfe6008a34a
Release implicit grabs as soon as we handle events.
Implicit keyboard grabs which are created by the pressing and holding of a key
that was passively grabbed by XGrabKey are evil for a number of reasons.First
of all, there isn't any way to track them or to track which window they are
grabbed on so if a plugin makes an active grab and then releases it, the
passive grab is released on release, which means there is an inconsistency
between holding the key and having the grab. Secondly, if plugins actually
need a grab on all keys, they are better switching to an active grab
rather than relying on the passive one. Finally, if there is a passive grab by
another application by a key-modifier combo which has the same modifier mask
as the currently activated passive grab, then it means that this application
won't get its grab activated as long as the modifier is held down.
Implicit keyboard grabs which are created by the pressing and holding of a key
that was passively grabbed by XGrabKey are evil for a number of reasons.First
of all, there isn't any way to track them or to track which window they are
grabbed on so if a plugin makes an active grab and then releases it, the
passive grab is released on release, which means there is an inconsistency
between holding the key and having the grab. Secondly, if plugins actually
need a grab on all keys, they are better switching to an active grab
rather than relying on the passive one. Finally, if there is a passive grab by
another application by a key-modifier combo which has the same modifier mask
as the currently activated passive grab, then it means that this application
won't get its grab activated as long as the modifier is held down.
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
action.cpp |
2658 | 13 years ago | Sam Spilsbury | [PATCH] Be a little bit more clever when handing o | 12.3 KB |
|
|
|
actions.cpp |
2218 | 15 years ago | Danny Baumann | Remove key binding support from core. | 6.8 KB |
|
|
|
atoms.cpp |
2210 | 15 years ago | Danny Baumann | Adapt core for gnomecompat plugin addition. | 10.3 KB |
|
|
|
CMakeLists.txt |
2695 | 13 years ago | Sam Spilsbury | Fix the loading and installation of images - core | 1 KB |
|
|
|
event.cpp |
2726 | 13 years ago | Sam Spilsbury | Release implicit grabs as soon as we handle events | 49.8 KB |
|
|
|
eventsource.cpp |
2679 | 13 years ago | Sam Spilsbury | s/Novell Inc./Canonical Ltd./ in eventsource.cpp c | 2.4 KB |
|
|
|
icon.cpp |
2390.1.12 | 14 years ago | Erkin Bahceci | Delete array with delete []. | 1.5 KB |
|
|
|
main.cpp |
2609.6.59 | 13 years ago | Sam Spilsbury | Fix buffer overflow on some platforms (Non NULL pa | 5.4 KB |
|
|
|
match.cpp |
2360 | 14 years ago | Erkin Bahceci | Fix some compiler warnings. | 13.3 KB |
|
|
|
modifierhandler.cpp |
2609.7.16 | 13 years ago | Sam Spilsbury | Fix grabs activating when we don't need them to, f | 4.8 KB |
|
|
|
option.cpp |
2609.1.64 | 13 years ago | Sam Spilsbury | Make sure that we properly unregister actions when | 18.5 KB |
|
|
|
output.cpp |
2390.1.9 | 14 years ago | Erkin Bahceci | Unsigned int conversions. | 2.1 KB |
|
|
|
plugin.cpp |
2609.7.13 | 13 years ago | Sam Spilsbury | Fix crashes when loading plugins on the command li | 12.6 KB |
|
|
|
pluginclasses.cpp |
2390.1.13 | 14 years ago | Erkin Bahceci | Silence some warnings. | 2 KB |
|
|
|
point.cpp |
2433 | 14 years ago | Sam Spilsbury | Fix character encoding issue | 2.1 KB |
|
|
|
privateaction.h |
2654 | 13 years ago | Sam Spilsbury | Don't increase core action register reference coun | 1.6 KB |
|
|
|
privatematch.h |
2308 | 15 years ago | Danny Baumann | Whitespace fixes. | 2.2 KB |
|
|
|
privateoption.h |
2658 | 13 years ago | Sam Spilsbury | [PATCH] Be a little bit more clever when handing o | 2.5 KB |
|
|
|
privateregion.h |
2665.1.2 | 13 years ago | Jason Smith | Fix compregion to be a more true to form wrapper o | 1.4 KB |
|
|
|
privatescreen.h |
2706 | 13 years ago | Sam Spilsbury | Process changes to edge windows when skipping even | 11.5 KB |
|
|
|
privatewindow.h |
2720 | 13 years ago | Sam Spilsbury | Don't treat synthetic UnmapNotify the same as the | 7.3 KB |
|
|
|
propertywriter.cpp |
2609.1.34 | 13 years ago | Sam Spilsbury | Use XFreeStringList to recursively free the entire | 5.3 KB |
|
|
|
rect.cpp |
2707.1.1 | 13 years ago | Rob Taylor | Region type in x is typedef struct _XRegion *Regio | 6 KB |
|
|
|
region.cpp |
2665.1.3 | 13 years ago | Jason Smith | Fix memory leaks introduced in last commit | 8 KB |
|
|
|
screen.cpp |
2706 | 13 years ago | Sam Spilsbury | Process changes to edge windows when skipping even | 107 KB |
|
|
|
session.cpp |
2707.1.3 | 13 years ago | Rob Taylor | If there's a sesion manager, ask it to always rest | 10.5 KB |
|
|
|
size.cpp |
2376 | 14 years ago | Dennis kasprzyk | Changed unsigned int to int to fix warnings | 1.4 KB |
|
|
|
string.cpp |
2386 | 14 years ago | Sam Spilsbury | Use <cstring> | 2.3 KB |
|
|
|
timer.cpp |
2678 | 13 years ago | Sam Spilsbury | Merge branch 'master' of git://git.compiz.org/comp | 5.3 KB |
|
|
|
window.cpp |
2720 | 13 years ago | Sam Spilsbury | Don't treat synthetic UnmapNotify the same as the | 130 KB |
|
|
|
windowgeometry.cpp |
2707 | 13 years ago | Sam Spilsbury | Reflect difference between actual input frame geom | 5.1 KB |
|
|