- Committer: Mikkel Kamstrup Erlandsen
- Date: 2012-07-12 07:13:07 UTC
- mfrom: (82.1.1 5.0)
- Revision ID: mikkel.kamstrup@gmail.com-20120712071307-ajvkqcf19fh47ekq
Backport from trunk: Fix u1 search results to not seem too random. Lowers mem churn in musicstore scope quite a bit.
This was rooted in the fact that musicsearch.ubuntu.com returns a mix of artists, albums, and tracks in the results. We do not show artists, so if the results contains mainly that, then we're screwed (even though there could be many potential track/album matches outside the fetched results). Luckily newer versions of the webservice contains some parameters to tweak this behaviour. This commit makes us use that.
In addition to using the new musicsearch API I also lowered memory churn quite considerably by removing the need to create a lot of Track/Album objects and do excessive string copying.
Approved by: mhr3. Fixes: https://bugs.launchpad.net/unity-lens-music/+bug/1021656
This was rooted in the fact that musicsearch.ubuntu.com returns a mix of artists, albums, and tracks in the results. We do not show artists, so if the results contains mainly that, then we're screwed (even though there could be many potential track/album matches outside the fetched results). Luckily newer versions of the webservice contains some parameters to tweak this behaviour. This commit makes us use that.
In addition to using the new musicsearch API I also lowered memory churn quite considerably by removing the need to create a lot of Track/Album objects and do excessive string copying.
Approved by: mhr3. Fixes: https://bugs.launchpad.net/unity-lens-music/+bug/1021656
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
data
|
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla |
|
||
|
po
|
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla |
|
||
|
src
|
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla |
|
||
acinclude.m4 |
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla | 967 bytes |
|
|
|
AUTHORS |
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla | 97 bytes |
|
|
autogen.sh |
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla | 187 bytes |
|
|
|
ChangeLog |
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla | Empty |
|
|
|
configure.ac |
82 | 11 years ago | Michal Hruby | Release 5.12.0 | 4.5 KB |
|
|
|
COPYING |
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla | 34.2 KB |
|
|
|
MAINTAINERS |
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla | 37 bytes |
|
|
|
Makefile.am |
41.1.4 | 12 years ago | Alex Launi | fix distcheck | 998 bytes |
|
|
|
music.lens.in.in |
63.1.1 | 12 years ago | Didier Roche | get right icon path | 313 bytes |
|
|
|
musicstore.scope |
41.1.1 | 12 years ago | Alex Launi | merge music store scope | 102 bytes |
|
|
|
NEWS |
63.2.1 | 12 years ago | Didier Roche | dummy commit for ABI rebuild | 2 bytes |
|
|
|
README |
1 | 12 years ago | Alex Launi | initial import of files lens, with some boiler pla | Empty |
|
|
|
TESTS-TODO.txt |
66.1.2 | 12 years ago | Michal Hruby | Add file explaining tests | 480 bytes |
|
|