-
Committer:
Tarmac
-
Author(s):
Mirco Müller
-
Date:
2012-03-13 17:20:30 UTC
-
mfrom:
(1970.2.2 unity.fix-863230)
-
Revision ID:
tarmac-20120313172030-mi771ozqyrmfnazh
Trying to understand how and where changes to an icons alpha- and saturation-value are taking place is material to get insane. By now I've spent many many many hours trying to get behind what's going on. I can't say I fully grasp
the intricate ways of icons opacity and saturation in class Launcher.
As far as I can tell, there are four valid "cases" for the launcher icons in terms of alpha and saturation. To make it easier for you to follow, have a look at this table:
alpha | saturation
-------------------------------------------------------------------
| dash open | 0.5 | 0.0 |
| dash closed | 1.0 | 1.0 |
| drop-target (dragging & dash open) | 1.0 | 1.0 |
| no drop-target (dragging & dash open) | 0.5 | 0.0 |
-------------------------------------------------------------------
So alpha should never be outside [0.5 .. 1.0] and saturation should never be outside [0.0 .. 1.0]. From my investigation it is sufficient to protect only against the lower threshold, where alpha needs to be 0.5 and saturation 0.0
without fix:
http://people.canonical.com/~mmueller/863230-issue-1.ogv
with fix:
http://people.canonical.com/~mmueller/after-fix-863230.ogv
If anybody ever causes this to regress, I'll ... !. Fixes: https://bugs.launchpad.net/bugs/863230. Approved by Tim Penhey.