-
Committer:
Bileto Bot
-
Author(s):
Michael Terry
-
Date:
2016-06-17 01:18:08 UTC
-
mfrom:
(2440.8.2 robustify-tutorial-qmltests)
-
Revision ID:
ci-train-bot@canonical.com-20160617011808-p2m9uv7v5q7pn0s4
Make tutorial qmltests more robust.
Use the tutorial Loader objects instead of the tutorial objects themselves when checking that the tutorial objects are hidden or shown.
Individual tutorial objects are unloaded when they have been completed and their hide animations are done running. But their loaders are always available.
Individual tutorial objects used to always be available. But when I refactored things a little while ago, I changed that and didn't update the tests because I didn't notice the race I had created.
The race happens because when the tests do "swipe to dismiss tutorial" and then check that the tutorial is !shown, if we finish the hide animation first and unload the object, the check will fail.
So instead, check the loaders for shown/hidden state. (LP: #1590810)