← Back to branch summary

~unity8-desktop-session-team/indicator-session/indicator-session-using-upstart

« back to all changes in this revision

Viewing changes to MERGE-REVIEW

  • Committer: Charles Kerr
  • Date: 2013-07-02 00:26:11 UTC
  • mto: This revision was merged to the branch mainline in revision 399.
  • Revision ID: charles.kerr@canonical.com-20130702002611-lhtxz8ouz9uc2ldx
in cmake/Translations.cmake, use the GNUInstallDirs variables

Show diffs side-by-side

added added

removed removed

Lines of Context:
MERGE-REVIEW
1
 
 
2
 
This documents the expections that the project has on what both submitters
3
 
and reviewers should ensure that they've done for a merge into the project.
4
 
 
5
 
== Submitter Responsibilities ==
6
 
 
7
 
 * Ensure the project compiles and the test suite executes without error
8
 
 * Ensure that non-obvious code has comments explaining it
9
 
 * If the change works on specific profiles, please include those in the merge description.
10
 
 
11
 
== Reviewer Responsibilities ==
12
 
 
13
 
 * Did the Jenkins build compile?  Pass?  Run unit tests successfully?
14
 
 * Are there appropriate tests to cover any new functionality?
15
 
 * If the description says this effects the phone profile:
16
 
   * Run tests indicator-session/unity8*
17
 
 * If the description says this effects the desktop profile:
18
 
   * Run tests indicator-session/unity7*
19