~vanvugt/mir/unocclude

Viewing all changes in revision 1558.

  • Committer: Tarmac
  • Author(s): Alberto Aguirre
  • Date: 2014-04-16 14:49:54 UTC
  • mfrom: (1537.2.14 fix-1296544)
  • Revision ID: tarmac-20140416144954-8odslnim2qb1r3hs
Make MultiThreadedCompositor::start and MultiThreadedCompositor::stop exception safe.

Also to keep helgrind happy (LP: #1296544) allow it to establish a correct mutex locking order by avoiding holding the start guard lock while configuring the scene change callback in MultiThreadedCompositor::start.

Add a test to ensure start can safely be called again even if previous attempts resulted in an exception. Fixes: https://bugs.launchpad.net/bugs/1296544.

Approved by Alan Griffiths, PS Jenkins bot, Robert Carr, Alexandros Frantzis, Chris Halse Rogers.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: