← Back to branch summary

~vcs-imports/alsa-plugins/trunk

  • Committer: Takashi Iwai
  • Author(s): Stian Skjelstad
  • Date: 2019-05-05 07:43:31 UTC
  • Revision ID: git-v1:bb69c032a508a5b84a271692fb989ce9938d1b38
maemo: Fix a few crashing bugs

maemo plugin has two crashes I was able to see in a valgrind log from
another user:

* maximum write size was calculated in words (16bit), but checked against
  byte-size length. This causes memcpy later to overflow the buffer
  (normally by up to 12KB).
* remove a double free (by marking free'd data with NULL)

* mmap returns MMAP_FAILED on error, not NULL

I suspect that this plugin/driver might have other issues aswell, since I
am unable to find any logic for checking DSP buffer status, and no
implementation for odelay reporting.

Signed-off-by: Stian Skjelstad <stian.skjelstad@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Filename Latest Rev Last Changed Committer Comment Size
..
a52 38 18 years ago Takashi Iwai Add a52 output plugin Added (experimental) a52 ou Diff
aaf 319 5 years ago Jaroslav Kysela aaf: Introduce plugin skeleton The patch introduc Diff
arcam-av 194 15 years ago Takashi Iwai Add arcam-av plugin Added arcam-av control plugin Diff
doc 20 18 years ago Takashi Iwai Structure reorganziation, added polyp plugin - Re Diff
jack 20 18 years ago Takashi Iwai Structure reorganziation, added polyp plugin - Re Diff
m4 181 15 years ago Diego E. 'Flameeyes' Pettenò Add the attributes.m4 macro file from xine/lscube. Diff
maemo 68 17 years ago Takashi Iwai Alsa support for Maemo SDK (n770): Header files T Diff
mix 31 18 years ago Takashi Iwai Add upmix and vdownmix plugins Added PCM upmix an Diff
oss 20 18 years ago Takashi Iwai Structure reorganziation, added polyp plugin - Re Diff
pph 88 17 years ago Takashi Iwai Add rate resampler plugin based on speex Added an Diff
pulse 57 17 years ago Takashi Iwai Follow Polypaudio/PulseAudio name change Polypaud Diff
rate 35 18 years ago Takashi Iwai Add samplerate rate converter plugin Added a rate Diff
rate-lav 295 6 years ago Jaroslav Kysela Move rate-lavc to rate-lav subdirectory and update Diff
speex 192 15 years ago Takashi Iwai Add Speex pre-processing plugin Added Speex pre-p Diff
usb_stream 141 15 years ago Takashi Iwai Add usb_stream PCM plugin usb_stream PCM plugin i Diff
.gitignore 181 15 years ago Diego E. 'Flameeyes' Pettenò Add the attributes.m4 macro file from xine/lscube. 373 bytes Diff Download File
acinclude.m4 6 19 years ago Jaroslav Kysela packaging related changes 172 bytes Diff Download File
configure.ac 344 5 years ago Takashi Iwai configure: Fix unexpanded ALSA_DATA_DIR When no - 9.4 KB Diff Download File
COPYING 285 6 years ago Jaroslav Kysela Change FSF address (Franklin Street) Signed-off-b 25.8 KB Diff Download File
COPYING.GPL 285 6 years ago Jaroslav Kysela Change FSF address (Franklin Street) Signed-off-b 17.5 KB Diff Download File
File cvscompile 35 18 years ago Takashi Iwai Add samplerate rate converter plugin Added a rate 370 bytes Diff Download File
File gitcompile 126 15 years ago Jaroslav Kysela removed .hg* files and renamed hgcompile to gitcom 370 bytes Diff Download File
install-hooks.am 296 6 years ago Jaroslav Kysela configure: change --with-alsaaddondir to --with-al 503 bytes Diff Download File
Makefile.am 319 5 years ago Jaroslav Kysela aaf: Introduce plugin skeleton The patch introduc 879 bytes Diff Download File