~vcs-imports/libice/master : changes

~vcs-imports/libice/master » Changes from revision 154

From Revision 154 to 135

Rev	Summary	Authors	Tags	Date
154	Kill off local ICE_t definitions Kill off local ICE_t definitions Already defined at global scale in configure.ac Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)	Emil Velikov		6 years ago
153	Remove unneeded ^L symbols. Remove unneeded ^L symbols. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)	Emil Velikov		6 years ago
152	Kill off Time_t macro Kill off Time_t macro Analogous to previous commit, including the megacommit that removed the need for it. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)	Emil Velikov		6 years ago
151	Kill off Strstr macro Kill off Strstr macro Directly use the strstr function as opposed to wrapping it in a macro. The latter is no longer needed as of commit 72e353567f8927996a26e72848d86f692c3f0737 Author: Kaleb Keithley <kaleb@freedesktop.org> Date: Fri Nov 14 16:48:46 2003 +0000 XFree86 4.3.0.1 Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)	Emil Velikov		6 years ago
150	Use getentropy() if arc4random_buf() is not available Use getentropy() if arc4random_buf() is not available This allows to fix CVE-2017-2626 on Linux platforms without pulling in libbsd. The libc getentropy() is available since glibc 2.25 but also on OpenBSD. For Linux, we need at least a v3.17 kernel. If the recommended arc4random_buf() function is not available, emulate it by first trying to use getentropy() on a supported glibc and kernel. If the call fails, fall back to the current (partly vulnerable) code. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Reviewed-by: Mark Kettenis <kettenis@openbsd.org> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>	Benjamin Tissoires		7 years ago
149	autogen: add default patch prefix autogen: add default patch prefix Signed-off-by: Mihail Konev <k.mvc@ya.ru>	Mihail Konev		7 years ago
148	autogen.sh: use quoted string variables autogen.sh: use quoted string variables Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>	Emil Velikov		7 years ago
147	autogen.sh: use exec instead of waiting for configure to fin... autogen.sh: use exec instead of waiting for configure to finish Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>	Peter Hutterer		7 years ago
146	Fix use after free on subsequent calls Fix use after free on subsequent calls The function IceAuthFileName is vulnerable to a use after free. The flaw can be triggered by calling the function three times: - First call succeeds and stores the path in buf, a dynamically allocated buffer with size bsize. - Second call fails due to out of memory. It frees buf, but keeps the old size in bsize. - Third call only checks if bsize is large enough. Then it uses buf without allocating it again -- the use after free happens. In order to exploit this, an attacker must change environment variables between each call, namely ICEAUTHORITY or HOME. It also takes subsequent calls. Due to these limitations, I don't consider this to be of high priority. Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>	Tobias Stoeckmann		7 years ago
145	Bug 90616 - libICE build fails on array bounds check Bug 90616 - libICE build fails on array bounds check https://bugs.freedesktop.org/show_bug.cgi?id=90616 Recent versions of gcc have array bounds checking turned on by default, this leads to build failures of libICE. As the _IceVersionCount variable in ICElibint.h is not declared const the compiler cannot assume that the nested for loop in ProcessConnectionSetup stays within bounds. The simple fix is of course to change the declarations of _IceVersionCount, _IceVersions, and the local variable myVersionCount to const declarations. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Remko van der Vossen		8 years ago
144	Include unistd.h for getpid() Include unistd.h for getpid() Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk> Reviewed-by: David Macek <david.macek.0@gmail.com>	Jon TURNEY		9 years ago
143	spec: Convert troff \Q..\U to DocBook <quote>...</quote> spec: Convert troff \Q..\U to DocBook <quote>...</quote> Reported-by: Jasper St. Pierre <jstpierre@mecheye.net> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>	Alan Coopersmith		9 years ago
142	libICE 1.0.9 libICE 1.0.9 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith	libICE-1.0.9	9 years ago
141	Delete unused name variable in register.c Delete unused name variable in register.c Found by cppcheck 1.62: [src/register.c:84]: (style) Variable 'name' is assigned a value that is never used. [src/register.c:182]: (style) Variable 'name' is assigned a value that is never used. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		10 years ago
140	Free iceConn->connection_string when unwinding after malloc ... Free iceConn->connection_string when unwinding after malloc fails Found by cppcheck 1.62: [src/accept.c:113]: (error) Memory leak: iceConn.connection_string Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		10 years ago
139	Use arc4random when available to produce the auth cookie. Use arc4random when available to produce the auth cookie. arc4random() and associated functions can be found in libbsd on GNU/Linux systems. Signed-off-by: Matthieu Herrb <matthieu.herrb@laas.fr> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Matthieu Herrb		10 years ago
138	Make STORE_STRING cast strlen result to CARD16 when storing ... Make STORE_STRING cast strlen result to CARD16 when storing in CARD16 Clears a number of clang warnings of the form: connect.c:328:6: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'CARD16' (aka 'unsigned short') [-Wconversion] STORE_STRING (pData, _IceAuthNames[i]); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./ICElibint.h:173:19: note: expanded from macro 'STORE_STRING' CARD16 _len = strlen (_string); \ ~~~~ ^~~~~~~~~~~~~~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		10 years ago
137	Cast assignments in IceErrorHeader() macro Cast assignments in IceErrorHeader() macro Clears many clang warnings about implicit conversions losing integer precision, such as from storing ints into CARD8 or CARD16. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		10 years ago
136	Make write_string call write_counted_string instead of copyi... Make write_string call write_counted_string instead of copying it Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		10 years ago
135	Mark input arguments to write_string functions as const Mark input arguments to write_string functions as const Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		10 years ago

Older »