~vcs-imports/libpixman/master : changes

~vcs-imports/libpixman/master » Changes from revision 2188

From Revision 2153 to 2134

Rev	Summary	Authors	Date
2153	Avoid out-of-bounds read when accessing individual bytes fro... Avoid out-of-bounds read when accessing individual bytes from mask. The important changes here are a handful of places where we replace memcpy(&m, mask++, sizeof(uint32_t)); or similar code with uint8_t m = mask++; because we're only supposed to be reading a single byte from mask, and accessing a 32-bit value may read out of bounds (besides that it reads values we don't actually want; whether this matters would depend exactly how the value in m is subsequently used). I've also changed a bunch of other places to use this same pattern (a local 8-bit variable) when reading individual bytes from the mask; the code was inconsistent about this, sometimes casting the byte to a uint32_t instead. This makes no actual difference, it just seemed better to use a consistent pattern throughout the file.	Jonathan Kew	2 years ago
2152	meson: update option descriptions. meson: update option descriptions. - gtk is only used in demos - libpng is only used in tests - openmp is only used in tests (in the standard build)	Érico Rolim	3 years ago
2151	meson: remove pixman dependency meson: remove pixman dependency AFAICT from the git history, what happened is that the gtk demos rely on gtk being built with pixman support. pkg-config isn't really expressive enough to have that information, so the solution that was come up with was to search for pixman as well as gtk+ and hope that pixman being installed was. This isn't actually used anywhere in the meson build anyway, and it's causing problems for projects that want to use pixman as a supproject (there's a port of cairo underway that's hitting this), because it confuses meson.	Dylan Baker	3 years ago
2150	meson: add option to skip building of tests and demos meson: add option to skip building of tests and demos Reviewed-by: Dylan Baker <dylan@pnwbakers.com>	Tim-Philipp Müller	3 years ago
2149	meson: add cpu-features-path option for Android meson: add cpu-features-path option for Android Add option to include cpu-features.[ch] from a given path into the build for platforms that don't provide this out of the box. This is needed on Android. Reviewed-by: Dylan Baker <dylan@pnwbakers.com>	Tim-Philipp Müller	3 years ago
2148	Update README a little Update README a little - bugzilla -> gitlab - convert links to https - suggest issues and patches be filed via gitlab	Tim-Philipp Müller	3 years ago
2147	Add -ftrapping-math to default cflags Add -ftrapping-math to default cflags This should resolve https://gitlab.freedesktop.org/pixman/pixman/-/issues/22 and make the tests pass with clang. -ftrapping-math is already the default[1] for gcc, so this should not change behavior when compiling with gcc. However, clang defaults[2] to -fno-trapping-math, so -ftrapping-math is needed to avoid floating-point expceptions when running the combiner and stress tests. The root causes of this issue is that that pixman-combine-float.c guards floating-point division operations with a FLOAT_IS_ZERO check e.g. if (FLOAT_IS_ZERO (sa)) f = 1.0f; else f = CLAMP (da / sa); With -fno-trapping-math, the compiler assumes that division will never trap, so it may re-order the division and the guard and execute the division first. In most cases, this would not be an issue, because floating-point exceptions are ignored. However, these tests call enable_divbyzero_exceptions() which causes the SIGFPE signal to be sent to the program when a divide by zero exception is raised. [1] https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html [2] https://clang.llvm.org/docs/UsersManual.html#controlling-floating-point-behavior	Tom Stellard	3 years ago
2146	Prevent empty top-level declaration Prevent empty top-level declaration The expansion of PIXMAN_DEFINE_THREAD_LOCAL(...) may end in a function definition, so the following semicolon is considered an empty top-level declaration, which is not allowed in ISO C. Reviewed-by: Matt Turner <mattst88@gmail.com>	Michael Forney	4 years ago
2145	Post-release version bump to 0.40.1 Post-release version bump to 0.40.1 Signed-off-by: Matt Turner <mattst88@gmail.com>	Matt Turner	4 years ago
2144	Pre-release version bump to 0.40.0 Pre-release version bump to 0.40.0 Signed-off-by: Matt Turner <mattst88@gmail.com>	Matt Turner	4 years ago
2143	Move from MD5/SHA1 to SHA256/SHA512 digests Move from MD5/SHA1 to SHA256/SHA512 digests Signed-off-by: Matt Turner <mattst88@gmail.com>	Matt Turner	4 years ago
2142	Build xz tarballs instead of bzip2 Build xz tarballs instead of bzip2 Signed-off-by: Matt Turner <mattst88@gmail.com>	Matt Turner	4 years ago
2141	Distribute the blue-noise files Distribute the blue-noise files Signed-off-by: Matt Turner <mattst88@gmail.com>	Matt Turner	4 years ago
2140	Enabled armv6 SIMD for 3DS (devkitARM) and arm neon SIMD for... Enabled armv6 SIMD for 3DS (devkitARM) and arm neon SIMD for PS Vita (vitasdk) and Switch (devkitA64)	Ghabry	4 years ago
2139	loongson: Avoid C90 mixing-code-and-decls warning loongson: Avoid C90 mixing-code-and-decls warning	Matt Turner	4 years ago
2138	configure.ac: use '-mloongson-mmi' for Loongson MMI configure.ac: use '-mloongson-mmi' for Loongson MMI It's recommended to use '-mloongson-mmi' for MMI. Reviewed-by: Matt Turner <mattst88@gmail.com>	Shiyou Yin	4 years ago
2137	fast-path: Fix some sketchy pointer arithmetic fast-path: Fix some sketchy pointer arithmetic We want a uint8_t * at the end of this math, because that's what the function we're about to pass it to takes. But ->bits is a uint32_t, so if we just do the math in units of that we can avoid the explicit factor of four which would risk an integer overflow. Fixes: pixman/pixman#14	Adam Jackson	4 years ago
2136	lowlevel-blt-bench: Remove unused variable lowlevel-blt-bench: Remove unused variable Closes: https://gitlab.freedesktop.org/pixman/pixman/issues/7	Matt Turner	4 years ago
2135	Initialize temporary buffers in general_composite_rect() Initialize temporary buffers in general_composite_rect() Otherwise, Valgrind shows things like "conditional jump or move depends on uninitialised values" errors much later in calling code. For example, see https://gitlab.gnome.org/GNOME/librsvg/issues/572 Fixes https://gitlab.freedesktop.org/pixman/pixman/issues/9	Federico Mena Quinte...	4 years ago
2134	pixman-compiler.h: fix building tests with MinGW pixman-compiler.h: fix building tests with MinGW MinGW supports __declspec(dllexport) but the current logic that sets PIXMAN_EXPORT only uses it when building with MSVC, leaving some symbols hidden when building with MinGW. This results in an error when trying to link the tests: ----------------------------------------------------------------------- FAILED: subprojects/pixman/test/combiner-test.exe x86_64-w64-mingw32-gcc -o subprojects/pixman/test/combiner-test.exe 'subprojects/pixman/test/f48fa9c@@combiner-test@exe/combiner-test.c.obj' -Wl,--allow-shlib-undefined -Wl,--start-group subprojects/pixman/test/libtestutils.a subprojects/pixman/pixman/libpixman-1.dll.a -pthread -fopenmp -fopenmp -lm -mconsole -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 -Wl,--end-group /usr/bin/x86_64-w64-mingw32-ld: subprojects/pixman/test/f48fa9c@@combiner-test@exe/combiner-test.c.obj: in function `main': .../build/../subprojects/pixman/test/combiner-test.c:124: undefined reference to `_pixman_internal_only_get_implementation' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. ----------------------------------------------------------------------- By using PIXMAN_API also when building with MinGW, the tests can link successfully and the build succeed. Tested with x86_64-w64-mingw32-gcc (GCC) 8.3-win32 20191201.	Antonio Ospite	4 years ago