~vcs-imports/libpixman/master

Viewing all changes in revision 2175.

  • Committer: Matt Turner
  • Date: 2022-10-27 19:10:30 UTC
  • Revision ID: git-v1:c3bbb94b4c76292837a3b79322f8a678f106394f
Revert "Fix signed-unsigned semantics in reduce_32"

This reverts commit aaf59b0338fbd4b9142794254261f8d0a018b60c.

This commit regressed the scaling-test unit test, by apparently allowing
the compiler to emit fused multiply-add instructions in cases they
wouldn't have been allowed before. While using gcc's -ffp-contract=...
flag avoids the issue on amd64, it does not on at least aarch64 and
ppc64.

This is unfortunate, because the commit being reverted resolved
https://gitlab.freedesktop.org/pixman/pixman/-/issues/43 so we will
reintroduce this failure, but after more than a year without a fix for
the unit test, I think it's time to bite the bullet.

Fixes: https://gitlab.freedesktop.org/pixman/pixman/-/issues/49

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: