~vcs-imports/nano/master : changes

~vcs-imports/nano/master » Changes from revision 10199

From Revision 8886 to 8867

Rev	Summary	Authors	Date
8886	files: ignore errors when calling chown() on a backup file files: ignore errors when calling chown() on a backup file A normal user can change the group of a file (if the user is a member of that group), but cannot change the owner of that file. So, when a user edits a file that belongs to a different user, the call of fchown() will fail. But there is no harm in that. Also when the user is root, there is no harm in fchown() failing -- it will simply mean that the backup file will remain owned by root and will not be writable by the intended owner (when root has the normal umask of 0022). This fixes https://savannah.gnu.org/bugs/?58383. Bug existed since version 2.2.5, commit 86be3af7.	Benno Schulenberg	3 years ago
8885	tweaks: correct a comment, and drop a redundant (because nes... tweaks: correct a comment, and drop a redundant (because nested) #ifdef Also, drop an unneeded case-insensivity when comparing two strings, as all commands in a nanorc file have to be in lower case.	Benno Schulenberg	3 years ago
8884	build: do not let --disable-speller exclude also the formatt... build: do not let --disable-speller exclude also the formatter code In the past, when Speller and Linter and Formatter were all bound to ^T (later ones taking priority), it was easier to exclude also the formatter code when --disable-speller was used. But since the formatter was reintroduced (in commit 34170611) and bound to its own keystroke (M-F), this is no longer the case.	Benno Schulenberg	3 years ago
8883	tweaks: slightly improve the grouping of shortcuts in some h... tweaks: slightly improve the grouping of shortcuts in some help texts	Benno Schulenberg	3 years ago
8882	tweaks: order three menu names in the documentation slightly... tweaks: order three menu names in the documentation slightly better	Benno Schulenberg	3 years ago
8881	docs: copy the 4.9.3 news item from the release branch docs: copy the 4.9.3 news item from the release branch	Benno Schulenberg	3 years ago
8880	feedback: skip wiping the prompt bar when the shortcut print... feedback: skip wiping the prompt bar when the shortcut printed a message When, at a prompt, the user chose a function shortcut instead of typing an answer, and this function printed some message to the status bar, then we do not want to wipe this message. Also: the message overwrote and cleared the prompt bar, so there is no need to wipe the latter. This fixes https://savannah.gnu.org/bugs/?56273. Bug existed since version 4.0, since justifying started giving feedback (or rather since version 4.1, since M-J no longer crashed).	Benno Schulenberg	3 years ago
8879	tweaks: rename a symbol, away from a double abbreviation tweaks: rename a symbol, away from a double abbreviation	Benno Schulenberg	3 years ago
8878	tweaks: avoid a compiler warning tweaks: avoid a compiler warning	Benno Schulenberg	3 years ago
8877	prompt: at Yes-No, do not treat a screen resize as an invali... prompt: at Yes-No, do not treat a screen resize as an invalid keystroke Commit 12cf1c99 added a beep() for every invalid keystroke at the Yes-No prompt, but overlooked that KEY_WINCH is not invalid. This fixes https://savannah.gnu.org/bugs/?58422. Bug existed since version 4.8, commit 12cf1c99.	Benno Schulenberg	3 years ago
8876	display: do not try to draw content when there is no open bu... display: do not try to draw content when there is no open buffer yet Commit b63c90bf avoided creating an empty buffer before asking the yes-no question when encountering a lock file at startup, but the SIGWINCH code still expected to have an open buffer whose contents to show. This fix also has the pleasant effect that, when resizing the screen at the lock-file yes-no prompt, the title bar doesn't suddenly appear. This fixes https://savannah.gnu.org/bugs/?58414. Reported-by: Liu Hao <lh_mouse@126.com> Bug existed since version 4.9, commit b63c90bf.	Benno Schulenberg	3 years ago
8875	tweaks: don't bother statting the lock file before unlinking... tweaks: don't bother statting the lock file before unlinking it If unlinking would fail because the parent directory is unwritable, then a check in has_valid_path() would have prevented do_lockfile() from being called at all.	Benno Schulenberg	3 years ago
8874	locking: prevent a symlink attack by not opening an existing... locking: prevent a symlink attack by not opening an existing lock file If in between the unlink() in delete_lockfile() and the fopen() in write_lockfile() some other process creates a symlink in the place of the lock file, then the fopen() could unexpectedly overwite a root-owned file (when the user is root). This basically reverts the previous commit, b4299f4f, but makes the code a bit conciser.	Benno Schulenberg	3 years ago
8873	tweaks: don't bother using the exclusive flag when creating ... tweaks: don't bother using the exclusive flag when creating a lock file One microsecond earlier, the lock file has been deleted (if it existed), so, if between our unlink() and our open() some other process managed to recreate the lock file... well, we want to delete it again. So, just overwrite and truncate the lock file (if it exists). When the lock file did NOT exist (a few microseconds earlier, when checking in do_lockfile(), before calling write_lockfile()), then the user expects the lock file to be written, so: just write it. That between the check and the actual writing of the lock file there is a small window of opportunity for other processes to write this lock file is unfortunate, but it is not a reason to bother the user with an error message when it happens.	Benno Schulenberg	3 years ago
8872	locking: ignore the insecure-backup flag when creating a loc... locking: ignore the insecure-backup flag when creating a lock file One microsecond before a lock file is created an existing lock file has been deleted, and if that deletion failed, writing the lock file is aborted. So why should writing the lock file not be aborted when the lock file cannot be exclusively created one microsecond later? This makes no sense. So... always include the O_EXCL flag, also when the INSECURE_BACKUP flag is set. (And anyway: lock files are not an essential part of editing, they are just a small service to the user, AND they have nothing to do with backups, so a backup flag should not influence them.)	Benno Schulenberg	3 years ago
8871	tweaks: add a symbol, in order to condense three function ca... tweaks: add a symbol, in order to condense three function calls	Benno Schulenberg	4 years ago
8870	tweaks: reshuffle an assignment, for conciseness, and rename... tweaks: reshuffle an assignment, for conciseness, and rename a variable	Benno Schulenberg	4 years ago
8869	tweaks: exclude a bit of bracketed-paste code from the tiny ... tweaks: exclude a bit of bracketed-paste code from the tiny version The tiny version does not support bracketed pastes.	Benno Schulenberg	4 years ago
8868	usage: unabbreviate option arguments where possible usage: unabbreviate option arguments where possible And make it clearer what kind of argument is expected: digits, characters, or a program name.	Benno Schulenberg	4 years ago
8867	tweaks: reshuffle a bit of code, to elide an #ifndef tweaks: reshuffle a bit of code, to elide an #ifndef	Benno Schulenberg	4 years ago