~vcs-imports/putty/master : changes

~vcs-imports/putty/master » Changes from revision 6759

From Revision 5455 to 5436

Rev	Summary	Authors	Date
5455	Uppity: free the packet protocol layers on exit. Uppity: free the packet protocol layers on exit. This bug and the one in the previous commit combined to mean that when an SSH-1 connection through Uppity is terminated, the pty backend for its main session channel was never cleaned up. (Firstly because ssh1_connection_free never got called, and secondly because that in turn forgot to free its mainchan.) The effect of that in turn was that a _subsequent_ connection to the same Uppity (using the new listening-socket mode) would likely reuse the same fd for its pty, and the insertions into the ptyfds tree in uxpty.c would silently fail because an existing Pty was already occupying them, leading to a segfault when that Pty in turn responded to events on a pty it didn't really own and tried to call back to a seat that didn't exist any more.	Simon Tatham	5 years ago
5454	SSH-1: free mainchan_chan on destruction. SSH-1: free mainchan_chan on destruction. We went through the tree234 of ordinary channels freeing the thing at the other end of each one, but of course in SSH-1 the main session channel is not stored in that tree due to its totally different shape in the protocol. So naturally I forgot to free _that_ one.	Simon Tatham	5 years ago
5453	SSH-1: disable trust sigils after session starts. SSH-1: disable trust sigils after session starts. This exactly replicates the way it's done in SSH-2: at the start of the connection layer we set the trust status to untrusted, and if that reports that it didn't give any indication to the user, we fall back to presenting an interactive anti-spoofing prompt. I don't know how I forgot to do that in SSH-1, and even more, how we haven't noticed for a month. We noticed the same bug in _Rlogin_ within a day of the 0.71 release, after all!	Simon Tatham	5 years ago
5452	ssh2connection: missing free of antispoof_prompt. ssh2connection: missing free of antispoof_prompt. Just noticed that if the session were to abort while that variable contains some allocated data, it wouldn't be freed.	Simon Tatham	5 years ago
5451	mainchan.c: rewrite handling of open-failure aborts. mainchan.c: rewrite handling of open-failure aborts. This is another case where a stale pointer bug could have arisen from a toplevel callback going off after an object was freed. But here, just adding delete_callbacks_for_context wouldn't help. The actual context parameter for the callback wasn't mainchan itself; it was a tiny separate object, allocated to hold just the parameters of the function the callback wanted to call. So if _those_ parameters became stale before the callback was triggered, then even delete_callbacks_for_context wouldn't have been able to help. Also, mainchan itself would have been freed moments after this callback was queued, so moving it to be a callback on mainchan itself wouldn't help. Solution: move the callback right out to Ssh, by introducing a new ssh_sw_abort_deferred() which is just like ssh_sw_abort but does its main work in a toplevel callback. Then ssh.c's existing call to delete_callbacks_for_context will clean it up if necessary.	Simon Tatham	5 years ago
5450	Add further missing delete_callbacks_for_context. Add further missing delete_callbacks_for_context. Having explicitly _stated_ in commit 4dcc0fddf the principle that if you ever queue a toplevel callback on a freeable object then you should also call delete_callbacks_for_context on that object before freeing it, I realised I'd never actually gone through and checked methodically at every call site of queue_toplevel_callback. So I did, and naturally, I found several missing ones.	Simon Tatham	5 years ago
5449	ssh2connection: clean up callbacks on exit. ssh2connection: clean up callbacks on exit. We use a toplevel callback in the SSH-2 connection layer for checking whether it's time to close the whole SSH session after a channel closes. If the channel close itself, or something close enough to it, involves a protocol error severe enough to abort the session and free the connection layer, then that callback can fire anyway on stale data. The fix is the same as it always is in these situations: any object which is ever used as the context parameter to queue_toplevel_callback should also be passed to delete_callbacks_for_context before freeing it.	Simon Tatham	5 years ago
5448	UDP: the 'mac' directory no longer exists. UDP: the 'mac' directory no longer exists.	Jacob Nevins	5 years ago
5447	Docs: tweaks in Feedback for the modern world. Docs: tweaks in Feedback for the modern world.	Jacob Nevins	5 years ago
5446	FAQ: misc tweaks for the modern world. FAQ: misc tweaks for the modern world.	Jacob Nevins	5 years ago
5445	Docs: list SSH specials before Telnet specials. Docs: list SSH specials before Telnet specials. No textual change apart from the rearrangement.	Jacob Nevins	5 years ago
5444	Docs: tweak PuTTYgen "public keys for pasting". Docs: tweak PuTTYgen "public keys for pasting". Use the control name displayed for SSH-2 keys, since that's overwhelmingly what people will care about these days.	Jacob Nevins	5 years ago
5443	Docs: talk about SSH-2 before SSH-1. Docs: talk about SSH-2 before SSH-1. Because SSH-1 is a very niche interest these days. Mostly this affects the public key documentation. Also, a couple of unrelated concessions to modernity.	Jacob Nevins	5 years ago
5442	Docs: tweak other error messages for truth. Docs: tweak other error messages for truth.	Jacob Nevins	5 years ago
5441	Docs: correct some error messages. Docs: correct some error messages. In some messages, "server" became "remote" in 21a7ce7a07.	Jacob Nevins	5 years ago
5440	Docs: reorder Bugs/More bugs docs to match code. Docs: reorder Bugs/More bugs docs to match code. The panels were rearranged in ab433e8073. No textual change other than the rearrangement.	Jacob Nevins	5 years ago
5439	Make docs match code for a couple of settings. Make docs match code for a couple of settings.	Jacob Nevins	5 years ago
5438	Cosmetic rearrangement of Terminal/Features panel. Cosmetic rearrangement of Terminal/Features panel. Move "Response to remote title query" next to "Disable remote-controlled window title changing"; that seems more logical, and matches the documentation.	Jacob Nevins	5 years ago
5437	Correct "Ed25519" orthography in Windows PuTTYgen. Correct "Ed25519" orthography in Windows PuTTYgen.	Jacob Nevins	5 years ago
5436	Rewrite "Getting started / Logging in". Rewrite "Getting started / Logging in". - Mention public key authentication - Define and describe the "terminal window" - Mention trust sigils - Describe here the lack of feedback in password prompts, as well as in the FAQ	Jacob Nevins	5 years ago