-
Committer:
Simon Tatham
-
Date:
2019-07-24 17:56:07 UTC
-
Revision ID:
git-v1:a6a13311b4e63c735cac9d6ac9ecedad752d31d7
Revert "Bounds-check terminal selection when clearing scrollback."
This reverts commit 80f5a009f647aacd492c6e1e7a5f450156cabe13.
After a bit more thought, I've decided it's the wrong way to solve the
problem. We shouldn't really be _changing_ the current selection
bounds in response to an event that touches the range they cover. With
this fix in place, if you clear the scrollback while a selection
partly overlaps it, and then extend the modified selection, you'll get
a selection one of whose endpoints is something you never specified as
a selection endpoint at all, and possibly paste the wrong text.
A better fix is to do the same thing we do about any other event that
touches the range covered by the selection: get rid of the selection
completely. For ease of cherry-picking (in case anyone needs to apply
the good fix in some downstream branch, or whatever), I'll make that
change separately in the next commit.