~vcs-imports/render/master

Viewing all changes in revision 69.

  • Committer: Alan Coopersmith
  • Date: 2013-05-05 23:00:55 UTC
  • Revision ID: git-v1:9e577d40322b9e3d8bdefec0eefa44d8ead451a4
integer overflow in XRenderQueryFormats() [CVE-2013-1987 2/3]

The length, numFormats, numScreens, numDepths, and numVisuals members of
the reply are all CARD32 and need to be bounds checked before multiplying
and adding them together to come up with the total size to allocate, to
avoid integer overflow leading to underallocation and writing data from
the network past the end of the allocated buffer.

Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: