~vcs-imports/render/master

Viewing all changes in revision 70.

  • Committer: Alan Coopersmith
  • Date: 2013-05-05 23:00:55 UTC
  • Revision ID: git-v1:786f78fd8df6d165ccbc81f306fd9f22b5c1551c
integer overflow in XRenderQueryPictIndexValues() [CVE-2013-1987 3/3]

The length and numIndexValues members of the reply are both CARD32 and
need to be bounds checked before multiplying by sizeof (XIndexValue) to
avoid integer overflow leading to underallocation and writing data from
the network past the end of the allocated buffer.

Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: