~vcs-imports/rtl-sdr/master

Viewing all changes in revision 377.

  • Committer: Steve Markgraf
  • Author(s): Derrick Pallas
  • Date: 2020-03-18 22:51:46 UTC
  • Revision ID: git-v1:d794155ba65796a76cd0a436f9709f4601509320
tuner_r82xx: fix short-write in r82xx_read

In r82xx_read, there is a 1-byte I2C write followed by the I2C read.  If
this I2C write fails, r82xx_read correctly bails out but may return 0.
Callers that check whether (rc < 0) will assume that the buffer was written
when it has not been, e.g. in r82xx_set_tv_standard where

        priv->fil_cal_code = data[4] & 0x0f;

consumes a garbage value for data[4].

This change resolves that issue by copying the error path from r82xx_write.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: