~vila/autopilot/timestamped-subunit-stream

Viewing all changes in revision 549.

  • Committer: Tarmac
  • Author(s): Albert Astals Cid
  • Date: 2015-04-07 22:32:31 UTC
  • mfrom: (548.1.1 autopilot)
  • Revision ID: tarmac-20150407223231-u95jlh266z4jqten
Create keyboard well before it's going to be used

Otherwise it can cause races when using the uinput keyboard in mir, e.g.

    Mir log says
      [1427285878.342107] android-input: [EventHub]New device: id=18, fd=66, path='/dev/input/event8', name='py-evdev-uinput', classes=0x80000063, configuration='', keyLayout='Generic.kl', keyCharacterMap='Generic.kcm', builtinKeyboard=false, usingSuspendBlockIoctl=true, usingClockIoctl=true

    autopilot log says
      12:17:58.305 DEBUG _uinput:60 - Pressing p (25).

25 March 2015 12:17:58.305 is 1427285878.305, that is, the key press is sent 37 milliseconds before mir sees the device, so that key press is lost.

Approved by Christopher Lee, PS Jenkins bot.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: