~vishvananda/nova/lp720393

  • Committer: Tarmac
  • Author(s): Salvatore Orlando
  • Date: 2011-02-15 17:30:19 UTC
  • mfrom: (654.2.4 Openstack-bug694935)
  • Revision ID: tarmac-20110215173019-flcnjldqj2cj0der
The proposed fix puts a VM which fails to spawn in a (new) 'FAILED' power state. It does not perform a clean-up.
This because the user needs to know what has happened to the VM he/she was trying to run. Normally, API users do not have access to log files. In this case, the only way for the user to know what happened to the instance is to query its state (e.g.: doing euca-describe-instances). If we perform a complete clean-up, no information about the instance which failed to spawn will be left.

For the NO_HOST_AVAILABLE error, which occurs when there is not enough RAM left on the host, the amount of available memory is now checked at the beginning of the spawn process. This way, if there is not enough RAM left on the host, the spawn process returns immediately.
A test case (spawn_not_enough_memory) has been added as well.

I understand adding a new value to the power_state enumeration might not be acceptable. In that case I will propose for merge a different branch in which we perform a complete clean-up.
However, I reckon we still to provide a way to inform the user the spawn process has failed.
Filename Latest Rev Last Changed Committer Comment Size
..
bin 1 14 years ago Jesse Andrews initial commit Diff
bzrplugins 254.1.1 13 years ago Soren Hansen Better log formatter for Nova. It's just like gnuc Diff
CA 1 14 years ago Jesse Andrews initial commit Diff
contrib 386.2.26 13 years ago Todd Willey Nova quickstart: move vish's novascript into contr Diff
doc 157.3.1 13 years ago Monty Taylor Updated sphinx layout to a two-dir layout like swi Diff
etc 469.7.1 13 years ago Todd Willey Use paste.deploy for running the api server. Diff
locale 536.1.1 13 years ago Monty Taylor Added babel/gettext build support. Diff
nova 1 14 years ago Jesse Andrews initial commit Diff
plugins 145.3.2 13 years ago Ewan Mellor Move the xenapi top level directory under plugins, Diff
smoketests 139 13 years ago Soren Hansen Merge with -core's diverged trunk. Diff
tools 139 13 years ago Soren Hansen Merge with -core's diverged trunk. Diff
.bzrignore 515.6.2 13 years ago Soren Hansen Less code generation. 200 bytes Diff Download File
.gitignore 182 13 years ago Tarmac Got the tree set for debian packaging. 125 bytes Diff Download File
.mailmap 647.1.3 13 years ago SuperStack Added my mail alias (Part of an experiment in usin 1.6 KB Diff Download File
Authors 655.1.2 13 years ago Bilal Akhtar Add my name to AUTHORS, remove parentheses from th 2.3 KB Diff Download File
babel.cfg 536.1.1 13 years ago Monty Taylor Added babel/gettext build support. 17 bytes Diff Download File
File builddeb.sh 139 13 years ago Soren Hansen Merge with -core's diverged trunk. 787 bytes Diff Download File
HACKING 139.2.2 13 years ago Jesse Andrews reorder imports spacing 1.3 KB Diff Download File
LICENSE 1 14 years ago Jesse Andrews initial commit 9.9 KB Diff Download File
MANIFEST.in 586.2.1 13 years ago Soren Hansen Add etc/ directory to tarball. 1 KB Diff Download File
pylintrc 375.2.1 13 years ago Eric Day PEP8 and pylint cleanup. There should be no functi 829 bytes Diff Download File
README 468.2.2 13 years ago Anne Gentle Minor spellchecking fixes 837 bytes Diff Download File
run_tests.py 639.2.1 13 years ago termie add logging.basicConfig() to tests 2.2 KB Diff Download File
File run_tests.sh 639.1.1 13 years ago termie Only run pep8 after tests if running all the tests 2.2 KB Diff Download File
setup.cfg 536.1.1 13 years ago Monty Taylor Added babel/gettext build support. 372 bytes Diff Download File
setup.py 611.2.2 13 years ago Monty Taylor Fixed a pep8 spacing issue. 3.4 KB Diff Download File