~wallyworld/juju-core/fast-lxc-everywhere : changes

~wallyworld/juju-core/fast-lxc-everywhere » Changes to state/cleanup.go from revision 2698

From Revision 2698

Rev	Summary	Authors	Tags	Date
2648	[r=dimitern] errors: Improve tests, unify interfaces, wrappi... [r=dimitern] errors: Improve tests, unify interfaces, wrapping The errors package is refactored so that for all errors defined there are 3 functions with consistent names: * Is<type>(error) bool Returns true if the error satifies <type> (i.e. it was created with one of the two constructors below for <type>. * New<type>(error, string) error Creates an error of <type> wrapping the given error and adding the prefix to the message. * <type>f(string, ...interface{}) error Creates an error of <type> with a message, formatted like fmt.Sprintf. Dropped "Error" from type and function names (as they already are in the "errors" package). Moved utils.ErrorContextf in here, renaming it to Maskf. A new helper called Contextf is added, which works similarly to Maskf, but preserves the original error when wrapping (if it's one of the known types), so that the Is<type>() satifiers will work on the wrapped error as well. Added automatic exhaustive testing for each error type in a way that makes it easier to add new types. Few drive-by fixes made while fixing the rest of the code base to use the new function names. I realize we should use errgo for such things, but we can easily change the errors package to use errgo internally later. https://codereview.appspot.com/87560043/ R=rogpeppe	Dimiter Naydenov		10 years ago
2567	[r=dimitern] state: Add machine networks and interfaces [r=dimitern] state: Add machine networks and interfaces Added a couple of entities (and related methods) in state: * Network - holds a name, CIDR and VLAN tag; used to describe actual configured networks that machines need to be on. * NetworkInterface - linked to a machine id and network name, holds the network interface name to MAC address mapping in state (MAC address as key for uniqueness); machines support adding one or more NICs. Renamed machine.Network() and st.networks to RequestedNetworks() and st.requestedNetworks (in code only, schema remains the same). This helps avoid confusion between the requested networks (to include/exclude on a machine, coming from the service; they are now called "requested networks"), and actually configured networks on a running machine (just "networks"). For now networks are immutable, can't be removed and NICs can be added to them only if their machine is not provisioned yet. NICs are only removed when the machine itself is removed. Provisioner API change: renamed Networks() to RequestedNetworks() which is fine, because Networks() was added recently and not released yet. We'll use the added machine NICs to show enabled networks in juju status later on, and they will be set at StartInstance() time inside the provisioner. Internally, MaaS provider changes will be needed to get NIC-to-MAC mapping for an acquired node and the list of networks for it. https://codereview.appspot.com/83070047/ R=fwereade	Dimiter Naydenov		10 years ago
2473	[r=dimitern] state: Add Machine.Networks() and create them [r=dimitern] state: Add Machine.Networks() and create them This adds a new method to state.Machine: Networks(), which returns any associated networks to include or exclude for the machine. Added a couple of extra fields to state.MachineTemplate: IncludeNetworks and ExcludeNetworks. Each time a new machine or container is created, if these are populated, they will be also saved in state for the machine, as a linked networksDoc. A few drive-by fixes for naming consistency, including changing Included/ExcludedNetworks across the codebase to Include/ExcludeNetworks to better illustrate the intent (i.e. we're saying what networks should be included or excluded, not how the reality is yet - we can do that post-provisioning only). Added tests to ensure when the new networkDocs are missing for a service/machine .Networks() still works and returns nil error, as suggested in reviews. https://codereview.appspot.com/79250044/ R=fwereade, gz	Dimiter Naydenov		10 years ago
2459	[r=fwereade],[bug=1217868] state: remove inappropriate D typ... [r=fwereade],[bug=1217868] state: remove inappropriate D type This moves the custom-defined "D" type to the mgo/bson included bson.D type.	Bodie Solomon	juju-1.17.6	10 years ago
2356	[r=gz] Merge 1.16 series into trunk [r=gz] Merge 1.16 series into trunk Pick up several bug fixes made for 1.16 minor releases to include with the upcoming 1.18 release. https://codereview.appspot.com/68810043/ R=dave-cheney	Curtis Hovey		10 years ago
2131	[r=axwalk] state: add Life to state.Environment [r=axwalk] state: add Life to state.Environment Environment has been given new methods to mark an environment as dying, and to remove the environment from state. An environment must now exist in state and be Alive for services or machines to be added to state. A secondary change here is to use the environment's UUID in the tag, rather than the environment's name, which is non-unique. We continue to accept the name as input, until we know all users are passing in UUIDs. https://codereview.appspot.com/28880043/	Andrew Wilkins		10 years ago
2129	[r=fwereade],[bug=1259473] state: forced machine cleanup jus... [r=fwereade],[bug=1259473] state: forced machine cleanup just sets Dead fixes lp:1259473 https://codereview.appspot.com/39970043/	William Reade		10 years ago
2099	[r=jameinel] tweak: just merge the 1.16 branch into trunk [r=jameinel] tweak: just merge the 1.16 branch into trunk This assumes that all changes currently in 1.16 are already in trunk (which seems to be a safe assumption). I did audit a few of the changes to make sure everything looked sane. I'm going to be doing some more 1.16 work, and if we can land on 1.16 and just merge into trunk then it will be easier, so this is a minor prereq. The only actual change that wasn't merged before was updating setup.iss which this includes. https://codereview.appspot.com/32720046/	Curtis Hovey		10 years ago
2045	[r=fwereade] state: add ForceDestroyMachines [r=fwereade] state: add ForceDestroyMachines Cleans up supplied machines, and everything using them, with extreme prejudice. https://codereview.appspot.com/23690043/	William Reade		10 years ago