1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
|
// Copyright 2013 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.
package names_test
import (
gc "launchpad.net/gocheck"
"launchpad.net/juju-core/names"
)
type tagSuite struct{}
var _ = gc.Suite(&tagSuite{})
var tagKindTests = []struct {
tag string
kind string
err string
}{
{tag: "unit-wordpress-42", kind: names.UnitTagKind},
{tag: "machine-42", kind: names.MachineTagKind},
{tag: "service-foo", kind: names.ServiceTagKind},
{tag: "environment-42", kind: names.EnvironTagKind},
{tag: "user-admin", kind: names.UserTagKind},
{tag: "relation-service1.rel1#other-svc.other-rel2", kind: names.RelationTagKind},
{tag: "relation-service.peerRelation", kind: names.RelationTagKind},
{tag: "foo", err: `"foo" is not a valid tag`},
{tag: "unit", err: `"unit" is not a valid tag`},
{tag: "network", err: `"network" is not a valid tag`},
{tag: "network-42", kind: names.NetworkTagKind},
}
func (*tagSuite) TestTagKind(c *gc.C) {
for i, test := range tagKindTests {
c.Logf("test %d: %q -> %q", i, test.tag, test.kind)
kind, err := names.TagKind(test.tag)
if test.err == "" {
c.Assert(test.kind, gc.Equals, kind)
c.Assert(err, gc.IsNil)
} else {
c.Assert(kind, gc.Equals, "")
c.Assert(err, gc.ErrorMatches, test.err)
}
}
}
var parseTagTests = []struct {
tag string
expectKind string
resultId string
resultErr string
}{{
tag: "machine-10",
expectKind: names.MachineTagKind,
resultId: "10",
}, {
tag: "machine-10-lxc-1",
expectKind: names.MachineTagKind,
resultId: "10/lxc/1",
}, {
tag: "foo",
expectKind: names.MachineTagKind,
resultErr: `"foo" is not a valid machine tag`,
}, {
tag: "machine-#",
expectKind: names.MachineTagKind,
resultErr: `"machine-#" is not a valid machine tag`,
}, {
tag: "unit-wordpress-0",
expectKind: names.UnitTagKind,
resultId: "wordpress/0",
}, {
tag: "unit-rabbitmq-server-0",
expectKind: names.UnitTagKind,
resultId: "rabbitmq-server/0",
}, {
tag: "foo",
expectKind: names.UnitTagKind,
resultErr: `"foo" is not a valid unit tag`,
}, {
tag: "unit-#",
expectKind: names.UnitTagKind,
resultErr: `"unit-#" is not a valid unit tag`,
}, {
tag: "service-wordpress",
expectKind: names.ServiceTagKind,
resultId: "wordpress",
}, {
tag: "service-#",
expectKind: names.ServiceTagKind,
resultErr: `"service-#" is not a valid service tag`,
}, {
tag: "unit-wordpress-0",
expectKind: "machine",
resultErr: `"unit-wordpress-0" is not a valid machine tag`,
}, {
tag: "environment-foo",
expectKind: names.EnvironTagKind,
resultId: "foo",
}, {
tag: "relation-my-svc1.myrel1#other-svc.other-rel2",
expectKind: names.RelationTagKind,
resultId: "my-svc1:myrel1 other-svc:other-rel2",
}, {
tag: "relation-riak.ring",
expectKind: names.RelationTagKind,
resultId: "riak:ring",
}, {
tag: "environment-/",
expectKind: names.EnvironTagKind,
resultErr: `"environment-/" is not a valid environment tag`,
}, {
tag: "user-foo",
expectKind: names.UserTagKind,
resultId: "foo",
}, {
tag: "user-/",
expectKind: names.UserTagKind,
resultErr: `"user-/" is not a valid user tag`,
}, {
tag: "network-",
expectKind: names.NetworkTagKind,
resultErr: `"network-" is not a valid network tag`,
}, {
tag: "network-mynet1",
expectKind: names.NetworkTagKind,
resultId: "mynet1",
}, {
tag: "foo",
expectKind: "",
resultErr: `"foo" is not a valid tag`,
}}
var makeTag = map[string]func(id string) string{
names.MachineTagKind: names.MachineTag,
names.UnitTagKind: names.UnitTag,
names.ServiceTagKind: names.ServiceTag,
names.RelationTagKind: names.RelationTag,
names.EnvironTagKind: names.EnvironTag,
names.UserTagKind: names.UserTag,
names.NetworkTagKind: names.NetworkTag,
}
func (*tagSuite) TestParseTag(c *gc.C) {
for i, test := range parseTagTests {
c.Logf("test %d: %q expectKind %q", i, test.tag, test.expectKind)
kind, id, err := names.ParseTag(test.tag, test.expectKind)
if test.resultErr != "" {
c.Assert(err, gc.ErrorMatches, test.resultErr)
c.Assert(kind, gc.Equals, "")
c.Assert(id, gc.Equals, "")
// If the tag has a valid kind which matches the
// expected kind, test that using an empty
// expectKind does not change the error message.
if tagKind, err := names.TagKind(test.tag); err == nil && tagKind == test.expectKind {
kind, id, err := names.ParseTag(test.tag, "")
c.Assert(err, gc.ErrorMatches, test.resultErr)
c.Assert(kind, gc.Equals, "")
c.Assert(id, gc.Equals, "")
}
} else {
c.Assert(err, gc.IsNil)
c.Assert(id, gc.Equals, test.resultId)
if test.expectKind != "" {
c.Assert(kind, gc.Equals, test.expectKind)
} else {
expectKind, err := names.TagKind(test.tag)
c.Assert(err, gc.IsNil)
c.Assert(kind, gc.Equals, expectKind)
}
// Check that it's reversible.
if f := makeTag[kind]; f != nil {
reversed := f(id)
c.Assert(reversed, gc.Equals, test.tag)
}
// Check that it parses ok without an expectKind.
kind1, id1, err1 := names.ParseTag(test.tag, "")
c.Assert(err1, gc.IsNil)
c.Assert(kind1, gc.Equals, test.expectKind)
c.Assert(id1, gc.Equals, id)
}
}
}
|