1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
|
// Copyright 2012, 2013 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.
package state_test
import (
jc "github.com/juju/testing/checkers"
gc "launchpad.net/gocheck"
"launchpad.net/juju-core/charm"
"launchpad.net/juju-core/errors"
"launchpad.net/juju-core/state"
)
type RelationSuite struct {
ConnSuite
}
var _ = gc.Suite(&RelationSuite{})
func (s *RelationSuite) TestAddRelationErrors(c *gc.C) {
wordpress := s.AddTestingService(c, "wordpress", s.AddTestingCharm(c, "wordpress"))
wordpressEP, err := wordpress.Endpoint("db")
c.Assert(err, gc.IsNil)
mysql := s.AddTestingService(c, "mysql", s.AddTestingCharm(c, "mysql"))
mysqlEP, err := mysql.Endpoint("server")
c.Assert(err, gc.IsNil)
riak := s.AddTestingService(c, "riak", s.AddTestingCharm(c, "riak"))
riakEP, err := riak.Endpoint("ring")
c.Assert(err, gc.IsNil)
// Check we can't add a relation with services that don't exist.
yoursqlEP := mysqlEP
yoursqlEP.ServiceName = "yoursql"
_, err = s.State.AddRelation(yoursqlEP, wordpressEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db yoursql:server": service "yoursql" does not exist`)
assertNoRelations(c, wordpress)
assertNoRelations(c, mysql)
// Check that interfaces have to match.
msep3 := mysqlEP
msep3.Interface = "roflcopter"
_, err = s.State.AddRelation(msep3, wordpressEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db mysql:server": endpoints do not relate`)
assertNoRelations(c, wordpress)
assertNoRelations(c, mysql)
// Check a variety of surprising endpoint combinations.
_, err = s.State.AddRelation(wordpressEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db": relation must have two endpoints`)
assertNoRelations(c, wordpress)
_, err = s.State.AddRelation(riakEP, wordpressEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db riak:ring": endpoints do not relate`)
assertOneRelation(c, riak, 0, riakEP)
assertNoRelations(c, wordpress)
_, err = s.State.AddRelation(riakEP, riakEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "riak:ring riak:ring": endpoints do not relate`)
assertOneRelation(c, riak, 0, riakEP)
_, err = s.State.AddRelation()
c.Assert(err, gc.ErrorMatches, `cannot add relation "": relation must have two endpoints`)
_, err = s.State.AddRelation(mysqlEP, wordpressEP, riakEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db mysql:server riak:ring": relation must have two endpoints`)
assertOneRelation(c, riak, 0, riakEP)
assertNoRelations(c, wordpress)
assertNoRelations(c, mysql)
// Check that a relation can't be added to a Dying service.
_, err = wordpress.AddUnit()
c.Assert(err, gc.IsNil)
err = wordpress.Destroy()
c.Assert(err, gc.IsNil)
_, err = s.State.AddRelation(mysqlEP, wordpressEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db mysql:server": service "wordpress" is not alive`)
assertNoRelations(c, wordpress)
assertNoRelations(c, mysql)
}
func (s *RelationSuite) TestRetrieveSuccess(c *gc.C) {
wordpress := s.AddTestingService(c, "wordpress", s.AddTestingCharm(c, "wordpress"))
wordpressEP, err := wordpress.Endpoint("db")
c.Assert(err, gc.IsNil)
mysql := s.AddTestingService(c, "mysql", s.AddTestingCharm(c, "mysql"))
mysqlEP, err := mysql.Endpoint("server")
c.Assert(err, gc.IsNil)
expect, err := s.State.AddRelation(wordpressEP, mysqlEP)
c.Assert(err, gc.IsNil)
rel, err := s.State.EndpointsRelation(wordpressEP, mysqlEP)
check := func() {
c.Assert(err, gc.IsNil)
c.Assert(rel.Id(), gc.Equals, expect.Id())
c.Assert(rel.String(), gc.Equals, expect.String())
}
check()
rel, err = s.State.EndpointsRelation(mysqlEP, wordpressEP)
check()
rel, err = s.State.Relation(expect.Id())
check()
}
func (s *RelationSuite) TestRetrieveNotFound(c *gc.C) {
subway := state.Endpoint{
ServiceName: "subway",
Relation: charm.Relation{
Name: "db",
Interface: "mongodb",
Role: charm.RoleRequirer,
Scope: charm.ScopeGlobal,
},
}
mongo := state.Endpoint{
ServiceName: "mongo",
Relation: charm.Relation{
Name: "server",
Interface: "mongodb",
Role: charm.RoleProvider,
Scope: charm.ScopeGlobal,
},
}
_, err := s.State.EndpointsRelation(subway, mongo)
c.Assert(err, gc.ErrorMatches, `relation "subway:db mongo:server" not found`)
c.Assert(err, jc.Satisfies, errors.IsNotFound)
_, err = s.State.Relation(999)
c.Assert(err, gc.ErrorMatches, `relation 999 not found`)
c.Assert(err, jc.Satisfies, errors.IsNotFound)
}
func (s *RelationSuite) TestAddRelation(c *gc.C) {
// Add a relation.
wordpress := s.AddTestingService(c, "wordpress", s.AddTestingCharm(c, "wordpress"))
wordpressEP, err := wordpress.Endpoint("db")
c.Assert(err, gc.IsNil)
mysql := s.AddTestingService(c, "mysql", s.AddTestingCharm(c, "mysql"))
mysqlEP, err := mysql.Endpoint("server")
c.Assert(err, gc.IsNil)
_, err = s.State.AddRelation(wordpressEP, mysqlEP)
c.Assert(err, gc.IsNil)
assertOneRelation(c, mysql, 0, mysqlEP, wordpressEP)
assertOneRelation(c, wordpress, 0, wordpressEP, mysqlEP)
// Check we cannot re-add the same relation, regardless of endpoint ordering.
_, err = s.State.AddRelation(mysqlEP, wordpressEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db mysql:server": relation already exists`)
_, err = s.State.AddRelation(wordpressEP, mysqlEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "wordpress:db mysql:server": relation already exists`)
assertOneRelation(c, mysql, 0, mysqlEP, wordpressEP)
assertOneRelation(c, wordpress, 0, wordpressEP, mysqlEP)
}
func (s *RelationSuite) TestAddRelationSeriesNeedNotMatch(c *gc.C) {
wordpress := s.AddTestingService(c, "wordpress", s.AddTestingCharm(c, "wordpress"))
wordpressEP, err := wordpress.Endpoint("db")
c.Assert(err, gc.IsNil)
mysql := s.AddTestingService(c, "mysql", s.AddSeriesCharm(c, "mysql", "otherseries"))
mysqlEP, err := mysql.Endpoint("server")
c.Assert(err, gc.IsNil)
_, err = s.State.AddRelation(wordpressEP, mysqlEP)
c.Assert(err, gc.IsNil)
assertOneRelation(c, mysql, 0, mysqlEP, wordpressEP)
assertOneRelation(c, wordpress, 0, wordpressEP, mysqlEP)
}
func (s *RelationSuite) TestAddContainerRelation(c *gc.C) {
// Add a relation.
wordpress := s.AddTestingService(c, "wordpress", s.AddTestingCharm(c, "wordpress"))
wordpressEP, err := wordpress.Endpoint("juju-info")
c.Assert(err, gc.IsNil)
logging := s.AddTestingService(c, "logging", s.AddTestingCharm(c, "logging"))
loggingEP, err := logging.Endpoint("info")
c.Assert(err, gc.IsNil)
_, err = s.State.AddRelation(wordpressEP, loggingEP)
c.Assert(err, gc.IsNil)
// Check that the endpoints both have container scope.
wordpressEP.Scope = charm.ScopeContainer
assertOneRelation(c, logging, 0, loggingEP, wordpressEP)
assertOneRelation(c, wordpress, 0, wordpressEP, loggingEP)
// Check we cannot re-add the same relation, regardless of endpoint ordering.
_, err = s.State.AddRelation(loggingEP, wordpressEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "logging:info wordpress:juju-info": relation already exists`)
_, err = s.State.AddRelation(wordpressEP, loggingEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "logging:info wordpress:juju-info": relation already exists`)
assertOneRelation(c, logging, 0, loggingEP, wordpressEP)
assertOneRelation(c, wordpress, 0, wordpressEP, loggingEP)
}
func (s *RelationSuite) TestAddContainerRelationSeriesMustMatch(c *gc.C) {
wordpress := s.AddTestingService(c, "wordpress", s.AddTestingCharm(c, "wordpress"))
wordpressEP, err := wordpress.Endpoint("juju-info")
c.Assert(err, gc.IsNil)
logging := s.AddTestingService(c, "logging", s.AddSeriesCharm(c, "logging", "otherseries"))
loggingEP, err := logging.Endpoint("info")
c.Assert(err, gc.IsNil)
_, err = s.State.AddRelation(wordpressEP, loggingEP)
c.Assert(err, gc.ErrorMatches, `cannot add relation "logging:info wordpress:juju-info": principal and subordinate services' series must match`)
}
func (s *RelationSuite) TestDestroyRelation(c *gc.C) {
wordpress := s.AddTestingService(c, "wordpress", s.AddTestingCharm(c, "wordpress"))
mysql := s.AddTestingService(c, "mysql", s.AddTestingCharm(c, "mysql"))
eps, err := s.State.InferEndpoints([]string{"wordpress", "mysql"})
c.Assert(err, gc.IsNil)
rel, err := s.State.AddRelation(eps...)
c.Assert(err, gc.IsNil)
// Test that the relation can be destroyed.
err = rel.Destroy()
c.Assert(err, gc.IsNil)
err = rel.Refresh()
c.Assert(err, jc.Satisfies, errors.IsNotFound)
assertNoRelations(c, wordpress)
assertNoRelations(c, mysql)
// Check that a second destroy is a no-op.
err = rel.Destroy()
c.Assert(err, gc.IsNil)
// Create a new relation and check that refreshing the old does not find
// the new.
_, err = s.State.AddRelation(eps...)
c.Assert(err, gc.IsNil)
err = rel.Refresh()
c.Assert(err, jc.Satisfies, errors.IsNotFound)
}
func (s *RelationSuite) TestDestroyPeerRelation(c *gc.C) {
// Check that a peer relation cannot be destroyed directly.
riakch := s.AddTestingCharm(c, "riak")
riak := s.AddTestingService(c, "riak", riakch)
riakEP, err := riak.Endpoint("ring")
c.Assert(err, gc.IsNil)
rel := assertOneRelation(c, riak, 0, riakEP)
err = rel.Destroy()
c.Assert(err, gc.ErrorMatches, `cannot destroy relation "riak:ring": is a peer relation`)
assertOneRelation(c, riak, 0, riakEP)
// Check that it is destroyed when the service is destroyed.
err = riak.Destroy()
c.Assert(err, gc.IsNil)
assertNoRelations(c, riak)
err = rel.Refresh()
c.Assert(err, jc.Satisfies, errors.IsNotFound)
// Create a new service (and hence a new relation in the background); check
// that refreshing the old one does not accidentally get the new one.
newriak := s.AddTestingService(c, "riak", riakch)
assertOneRelation(c, newriak, 1, riakEP)
err = rel.Refresh()
c.Assert(err, jc.Satisfies, errors.IsNotFound)
}
func assertNoRelations(c *gc.C, srv *state.Service) {
rels, err := srv.Relations()
c.Assert(err, gc.IsNil)
c.Assert(rels, gc.HasLen, 0)
}
func assertOneRelation(c *gc.C, srv *state.Service, relId int, endpoints ...state.Endpoint) *state.Relation {
rels, err := srv.Relations()
c.Assert(err, gc.IsNil)
c.Assert(rels, gc.HasLen, 1)
rel := rels[0]
c.Assert(rel.Id(), gc.Equals, relId)
name := srv.Name()
expectEp := endpoints[0]
ep, err := rel.Endpoint(name)
c.Assert(err, gc.IsNil)
c.Assert(ep, gc.DeepEquals, expectEp)
if len(endpoints) == 2 {
expectEp = endpoints[1]
}
eps, err := rel.RelatedEndpoints(name)
c.Assert(err, gc.IsNil)
c.Assert(eps, gc.DeepEquals, []state.Endpoint{expectEp})
return rel
}
|