1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
|
// Copyright 2013 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.
package state_test
import (
jc "github.com/juju/testing/checkers"
gc "launchpad.net/gocheck"
"launchpad.net/juju-core/state"
"launchpad.net/juju-core/utils"
)
type UserSuite struct {
ConnSuite
}
var _ = gc.Suite(&UserSuite{})
func (s *UserSuite) TestAddUserInvalidNames(c *gc.C) {
for _, name := range []string{
"foo-bar",
"",
"0foo",
} {
u, err := s.State.AddUser(name, "password")
c.Assert(err, gc.ErrorMatches, `invalid user name "`+name+`"`)
c.Assert(u, gc.IsNil)
}
}
func (s *UserSuite) TestAddUser(c *gc.C) {
u, err := s.State.AddUser("a", "b")
c.Check(u, gc.NotNil)
c.Assert(err, gc.IsNil)
c.Assert(u.Name(), gc.Equals, "a")
c.Assert(u.PasswordValid("b"), jc.IsTrue)
u1, err := s.State.User("a")
c.Check(u1, gc.NotNil)
c.Assert(err, gc.IsNil)
c.Assert(u1.Name(), gc.Equals, "a")
c.Assert(u1.PasswordValid("b"), jc.IsTrue)
}
func (s *UserSuite) TestCheckUserExists(c *gc.C) {
u, err := s.State.AddUser("a", "b")
c.Check(u, gc.NotNil)
c.Assert(err, gc.IsNil)
e, err := state.CheckUserExists(s.State, "a")
c.Assert(err, gc.IsNil)
c.Assert(e, gc.Equals, true)
e, err = state.CheckUserExists(s.State, "notAUser")
c.Assert(err, gc.IsNil)
c.Assert(e, gc.Equals, false)
}
func (s *UserSuite) TestSetPassword(c *gc.C) {
u, err := s.State.AddUser("someuser", "password")
c.Assert(err, gc.IsNil)
testSetPassword(c, func() (state.Authenticator, error) {
return s.State.User(u.Name())
})
}
func (s *UserSuite) TestAddUserSetsSalt(c *gc.C) {
u, err := s.State.AddUser("someuser", "a-password")
c.Assert(err, gc.IsNil)
salt, hash := state.GetUserPasswordSaltAndHash(u)
c.Check(hash, gc.Not(gc.Equals), "")
c.Check(salt, gc.Not(gc.Equals), "")
c.Check(utils.UserPasswordHash("a-password", salt), gc.Equals, hash)
c.Check(u.PasswordValid("a-password"), jc.IsTrue)
}
func (s *UserSuite) TestSetPasswordChangesSalt(c *gc.C) {
u, err := s.State.AddUser("someuser", "a-password")
c.Assert(err, gc.IsNil)
origSalt, origHash := state.GetUserPasswordSaltAndHash(u)
c.Check(origSalt, gc.Not(gc.Equals), "")
// Even though the password is the same, we take this opportunity to
// update the salt
u.SetPassword("a-password")
newSalt, newHash := state.GetUserPasswordSaltAndHash(u)
c.Check(newSalt, gc.Not(gc.Equals), "")
c.Check(newSalt, gc.Not(gc.Equals), origSalt)
c.Check(newHash, gc.Not(gc.Equals), origHash)
c.Check(u.PasswordValid("a-password"), jc.IsTrue)
}
func (s *UserSuite) TestSetPasswordHash(c *gc.C) {
u, err := s.State.AddUser("someuser", "password")
c.Assert(err, gc.IsNil)
err = u.SetPasswordHash(utils.UserPasswordHash("foo", utils.CompatSalt), utils.CompatSalt)
c.Assert(err, gc.IsNil)
c.Assert(u.PasswordValid("foo"), jc.IsTrue)
c.Assert(u.PasswordValid("bar"), jc.IsFalse)
// User passwords should *not* use the fast PasswordHash function
hash := utils.AgentPasswordHash("foo-12345678901234567890")
c.Assert(err, gc.IsNil)
err = u.SetPasswordHash(hash, "")
c.Assert(err, gc.IsNil)
c.Assert(u.PasswordValid("foo-12345678901234567890"), jc.IsFalse)
}
func (s *UserSuite) TestSetPasswordHashWithSalt(c *gc.C) {
u, err := s.State.AddUser("someuser", "password")
c.Assert(err, gc.IsNil)
err = u.SetPasswordHash(utils.UserPasswordHash("foo", "salted"), "salted")
c.Assert(err, gc.IsNil)
c.Assert(u.PasswordValid("foo"), jc.IsTrue)
salt, hash := state.GetUserPasswordSaltAndHash(u)
c.Assert(salt, gc.Equals, "salted")
c.Assert(hash, gc.Not(gc.Equals), utils.UserPasswordHash("foo", utils.CompatSalt))
}
func (s *UserSuite) TestPasswordValidUpdatesSalt(c *gc.C) {
u, err := s.State.AddUser("someuser", "password")
c.Assert(err, gc.IsNil)
compatHash := utils.UserPasswordHash("foo", utils.CompatSalt)
err = u.SetPasswordHash(compatHash, "")
c.Assert(err, gc.IsNil)
beforeSalt, beforeHash := state.GetUserPasswordSaltAndHash(u)
c.Assert(beforeSalt, gc.Equals, "")
c.Assert(beforeHash, gc.Equals, compatHash)
c.Assert(u.PasswordValid("bar"), jc.IsFalse)
// A bad password doesn't trigger a rewrite
afterBadSalt, afterBadHash := state.GetUserPasswordSaltAndHash(u)
c.Assert(afterBadSalt, gc.Equals, "")
c.Assert(afterBadHash, gc.Equals, compatHash)
// When we get a valid check, we then add a salt and rewrite the hash
c.Assert(u.PasswordValid("foo"), jc.IsTrue)
afterSalt, afterHash := state.GetUserPasswordSaltAndHash(u)
c.Assert(afterSalt, gc.Not(gc.Equals), "")
c.Assert(afterHash, gc.Not(gc.Equals), compatHash)
c.Assert(afterHash, gc.Equals, utils.UserPasswordHash("foo", afterSalt))
// running PasswordValid again doesn't trigger another rewrite
c.Assert(u.PasswordValid("foo"), jc.IsTrue)
lastSalt, lastHash := state.GetUserPasswordSaltAndHash(u)
c.Assert(lastSalt, gc.Equals, afterSalt)
c.Assert(lastHash, gc.Equals, afterHash)
}
func (s *UserSuite) TestName(c *gc.C) {
u, err := s.State.AddUser("someuser", "password")
c.Assert(err, gc.IsNil)
c.Assert(u.Name(), gc.Equals, "someuser")
c.Assert(u.Tag(), gc.Equals, "user-someuser")
}
func (s *UserSuite) TestDeactivate(c *gc.C) {
u, err := s.State.AddUser("someuser", "password")
c.Assert(err, gc.IsNil)
c.Assert(u.IsDeactivated(), gc.Equals, false)
err = u.Deactivate()
c.Assert(err, gc.IsNil)
c.Assert(u.IsDeactivated(), gc.Equals, true)
c.Assert(u.PasswordValid(""), gc.Equals, false)
}
func (s *UserSuite) TestCantDeactivateAdminUser(c *gc.C) {
u, err := s.State.User(state.AdminUser)
c.Assert(err, gc.IsNil)
err = u.Deactivate()
c.Assert(err, gc.ErrorMatches, "Can't deactivate admin user")
}
|