~wesley-wiedenmeier/curtin/1598310 : changes

~wesley-wiedenmeier/curtin/1598310 » Changes from revision 403

From Revision 403 to 384

Rev	Summary	Authors	Date
403	Add test for fallback lsblk entry selection in Add test for fallback lsblk entry selection in block.get_blockdev_sector_size	Wesley Wiedenmeier	7 years ago
402	In block.get_blockdev_sector_size, when falling back to firs... In block.get_blockdev_sector_size, when falling back to first entry in lsblk return dict, cast dict_keys object to list before indexing	Wesley Wiedenmeier	7 years ago
401	Add unittest for block.get_blockdev_sector_size Add unittest for block.get_blockdev_sector_size	Wesley Wiedenmeier	7 years ago
400	in block.get_blockdev_sector_size, it is possible that block... in block.get_blockdev_sector_size, it is possible that block._lsblock() will return multiple results. If this happens, then to find result information, either choose the result with the correct device_path attribute, or if none exists, the first result. resolves (lp: 1598310)	Wesley Wiedenmeier	7 years ago
399	Initial vmtest power8 support and TestSimple test. Initial vmtest power8 support and TestSimple test. This is not completely functional power8 tests, but does allow some tests to be run on power now. On a xenial ppc64el host, this will work: nosetests3 tests/vmtests/test_simple.py The TestSimple test pushes curtin through its "automatic" installation, that does not require storage config. power8 changes: - add a TestSimple that tests that curtin correctly installs when no storage config is provided (also runs on other arch). - tools/launch: generalize console_name (console=) for command line. - includes 'launch-by-label' branch (necessary for unstable virtio paths on different versions of qemu). helpers/common: - cleanups to prep partitioning in code to just be more readable. tools/xkvm minor improvements: - allow passing in 'file=/path/to/file.img' instead of just /path/to/file.img - allow shortened 'fmt=raw' in addition to 'format=raw'. tools/vmtest-sync-images can now take a release as an argument: ./tools/vmtest-sync-images xenial will sync xenial images and no others.	Scott Moser	7 years ago
398	tools/launch: boot by root=LABEL=cloudimg-rootfs tools/launch: boot by root=LABEL=cloudimg-rootfs We were previously booting with either root=/dev/vda or root=/dev/vda1 based on if the root disk was partitioned or not. That logic was sort of broken in that it didn't correctly query the backing device of a qcow2 disk. What prompted this change though is that using root= seems not reliable. On power8 kvm guests on 16.04 in current trunk, root=/dev/vda would not find a filesystem, where the same boot on 15.10 did. So for now, boot by LABEL=cloudimg-rootfs which is true for all of our vmtests.	Scott Moser	7 years ago
397	tools/launch and tools/xkvm: whitespace cleanup and bash -x tools/launch and tools/xkvm: whitespace cleanup and bash -x remove trailing whitespace and '-x' on shebang line.	Scott Moser	7 years ago
396	fix multipath configuration and add multipath tests fix multipath configuration and add multipath tests Xenial multipath fails without ensuring the multipath/bindings file is written with whitespace removed; this is triggered on in-target mulitpath versions >= 1.5.0. This fixes LP:1551937 Add multipath testing via a test-case option, cls.multipath which will if set to true, duplicate all disks in a test class. This has the effect of looking exactly like multipath setups where we see the same device with two paths. To handle devices with wwn or serial numbers with spaces in them curtin.block was updated to ensure it supports finding devices via there serial or wwn attribute. Specifically for serial numbers with spaces, we currently will escape the spaces to underscores; this is supported by observing the names that show up in /dev/disk/by-id/* for those devices. For wwn, /dev/disk/by-id/wwn-$wwn ; curtin resolves the symlink target to obtain a kernel devname for use with sysfs. For serial with spaces, curtin attempts to remove whitespace like udev to find the disk under /dev/disk/by-id/ and determine a devname.	Ryan Harper	7 years ago
395	vmtest: provide info on images used vmtest: provide info on images used This does 4 things, all in an effort to show which images are used. a.) fixes tests/vmtests/image_sync.py to actually use --output-format this was in its help, but ignored, now it works as expected. b.) provide image information at INFO level for each vmtest we'll now see a message like: Using tempdir: ... , Image: yakkety amd64/hwe-y 20160620 c.) provide image information at start of jenkins-runner jenkins-runner will now print: Working with images in /tmp/asdf precise amd64/hwe-p 20160610.1 precise amd64/hwe-q 20160610.1 .. yakkety amd64/hwe-y 20160620 d.) provide paths to each component of the image at DEBUG level	Scott Moser	7 years ago
394	curtin/net: use post-up for interface alias curtin/net: use post-up for interface alias When network config creates interface ip aliases, there may be a delay during network bring up due to no hotplug event being generated for aliased interfaces. This can be addressed by including a post-up hook on the main interface to call ifup on the aliased interface. This resolves a cloud-init 120 second timeout on Trusty.	Ryan Harper	7 years ago
393	tests/vmtests: add yakkety, remove vivid tests/vmtests: add yakkety, remove vivid Vivid is unsupported now, so remove those tests. Add Yakkety tests for any test that had a xenial test. The one thing that is questionable here is the usage of 'linux-generic' as the fallback, where previously there was none. The change means that linux-generic kernel would be installed even if there was a useful kernel installed in the image. Fix ifconfig output parsing to work for yakkety, And remove the code duplication by putting the ifconfig parser into helpers.	Ryan Harper	7 years ago
392	reporting: set webhook handler level to DEBUG, no filtering reporting: set webhook handler level to DEBUG, no filtering The webhook handler in curtin reporting included a default level of INFO and included a event filter which would not report events that were of lower importance than what was set. The result was for unconfigured WebHook handlers, some of the expected messages including post_files used by maas to collect the curtin install log were no longer sent. This patch sets WebHookHandler level to DEBUG, the same level set for LogHandler and PrintHandler, further we remove the event filtering. The events themselves include the level value and the event collector can apply their own filtering as needed. Along with the changes we clean up some comments and include a new unittest which specifically tests that a FinishReportingEvent with post_files is posted by the WebHookHandler.	Ryan Harper	7 years ago
391	improve net-meta network configuration improve net-meta network configuration when network configuration is not provided 'net-meta' would write a very simplistic /etc/network/interfaces file for each of the devices that were brought up in install environment. This had the following issues a.) it did not disable cloud-init networking b.) it did not account for naming of devices (causing issue if devices changed names between install and boot environment). c.) did not include interfaces.d as ideally it would. Now instead, we create a network config and let the appropriate renderer do the work.	Scott Moser	7 years ago
390	curtin/net: fix inet value for subnets, don't add interface ... curtin/net: fix inet value for subnets, don't add interface attributes to alias Apply two separate fixes for configuring bonding with ip aliases. Curtin re-used the interface's inet value for each subnet that might be configured. In the case where the configuration included an ipv4 address after an ipv6 one resulted in emitting 'inet6' for ipv4 address which is not correct. Resolve this issue by calculating the inet value independent of the current status of the iface, using the subnet config instead. When rendering a network_config which includes ip alias interfaces do not emit any attributes, like MTU, or bond/bridge options Including these values is almost always wrong or will result in confusing behavior on the target system.	Ryan Harper	7 years ago
389	Detect and remove legacy /etc/network/interfaces.d/eth0.cfg ... Detect and remove legacy /etc/network/interfaces.d/eth0.cfg from target Prior to Xenial release, Ubuntu Cloud images included a default network configuration in /etc/network/interfaces.d/eth0.conf. The presence of this legacy configuration file can cause a delay during boot when cloud- init is expecting a non-existent interface to become available. curtin installations handle configuring networking in the target installed system subsequently the embedded configuration is not needed. This patch reuses most of cloud-init's version of detecting and examining the legacy config, confirming if the contents are what is expected. Upon finding expected content the file will be removed, otherwise it will remain. Additional changes to vmtest and unittest were added to remove the reliance on fallback nic naming (eth0); we always use non-kernel names in our configuration now. An additional common test has been added to check that in all cases we ensure we remove the embedded config.	Ryan Harper	7 years ago
388	vmtests: Add Xenial to LVM test bucket. vmtests: Add Xenial to LVM test bucket.	Ryan Harper	7 years ago
387	fix timestamp in reporting events. fix timestamp in reporting events. If no timestamp was passed into a ReportingEvent, then the default was used. That default was 'time.time()' which was evaluated once only at import time.	Scott Moser	7 years ago
386	debian/control: add bcache-tools dependency debian/control: add bcache-tools dependency	Scott Moser	7 years ago
385	fix dependencies in packaging fix dependencies in packaging This fixes up dependencies to be more correct. The net result is that after 'apt-get install curtin', then curtin --install-deps will not have any work to do. curtin-common changes: - drop 'python' from curtin-common package as it does not use any python. - util-linux >= 2.20.1 is in all ubuntu (precise+) so remove this dependency as util-linux is 'essential' python-curtin, python3-curtin: - drop 'curl' from dependencies of python-curtin or python3-curtin this was simply incorrect. wget is used, but curl is never. - explicitly list the python dependencies on oauthlib and yaml the attempt to have dh_python resolve these was just simply not working. so explicitly list them. requirements.txt: - urllib3 is never used, drop it from here. - pbr is not needed. (it was probably copied from cloud-init)	Scott Moser	7 years ago
384	mdadm: resolve mdadm/bcache and trusty+hwe issues mdadm: resolve mdadm/bcache and trusty+hwe issues - mdadm must be installed before kernel update or grub fails - trusty bcache doesn't support sysfs entries, retry on failure when looking for an existing cache device - fix storage configuration where partition 'number' key was missing causing curtin to use reuse a partition (configuration error). - add some more debugging information when applying raid configurations - raid: add in use of homehost to ensure we find the right mdadm devices - unittests: fix up mdadm tests with introduced hostname -s call	Ryan Harper	8 years ago

Older »