1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
|
This documents the expections that the project has on what both submitters
and reviewers should ensure that they've done for a merge into the project.
== Submitter Responsibilities ==
* Ensure the project compiles and the test suite executes without error
* Ensure that non-obvious code has comments explaining it
== Reviewer Responsibilities ==
* Did the Jenkins build compile? Pass? Run unit tests successfully?
* Are there appropriate tests to cover any new functionality?
* If this MR effects application startup:
* Run test case: upstart-app-launch/click-app
* Run test case: upstart-app-launch/legacy-app
* Run test case: upstart-app-launch/secondary-activation
* If this MR effect untrusted-helpers:
* Run test case: upstart-app-launch/helper-run
|