~yadi/squid/te-gzip : changes

~yadi/squid/te-gzip » Changes from revision 14966

From Revision 14951 to 14932

Rev	Summary	Authors	Date
14951	Fix Null pointer dereferences after rev.14913 Fix Null pointer dereferences after rev.14913 on_unsupported_protocol with non-HTTP requests occurs without an HTTP request object. Some ACLs will not be possible to check but that is not a reason to crash. Detected by Coverity Scan. Issue 1394291.	Amos Jeffries	7 years ago
14950	TLS: Add ErrorString() function to libsecurity API TLS: Add ErrorString() function to libsecurity API To convert library error codes to strings in a library agnostic way.	Amos Jeffries	7 years ago
14949	Fix ICAP Allow header containing only trailers option Fix ICAP Allow header containing only trailers option r14941 added 'tailers' option to te Allow header but did not send it when only that option was used, without the 204 or 206 features. Detected by Coverity Scan. Issue 1394381.	Amos Jeffries	7 years ago
14948	Fix r14945: Fixed Write.cc:41 "!ccb->active()" assertion. Fix r14945: Fixed Write.cc:41 "!ccb->active()" assertion. The r14945 patch has a major bug: When the Http::One::Server::writeControlMsgAndCall fails to write the control message, schedules a Comm::Write callback using just a ScheduleCallHere command. The callback called withtout the CommIoCbParams details and squid is crashes. This patch fixes the ConnStateData::writeControlMsgAndCall to return false if it fails to write the control message and allow the caller to handle the failure. This is a Measurement Factory project	Christos Tsantilas	7 years ago
14947	SourceFormat Enforcement SourceFormat Enforcement	Source Maintenance	7 years ago
14946	Fix build tests error after r14945 patch: 'Fixed Write.cc:41 Fix build tests error after r14945 patch: 'Fixed Write.cc:41 "\!ccb->active()" assertion.'	Christos Tsantilas	7 years ago
14945	Fixed Write.cc:41 "!ccb->active()" assertion. Fixed Write.cc:41 "!ccb->active()" assertion. The following sequence of events triggers this assertion: - The server sends an 1xx control message. - http.cc schedules ConnStateData::sendControlMsg call. - Before sendControlMsg is fired, http.cc detects an error (e.g., I/O error or timeout) and starts writing the reply to the user. - The ConnStateData::sendControlMsg is fired, starts writing 1xx, and hits the "no concurrent writes" assertion. We could only reproduce this sequence in the lab after changing Squid code to trigger a timeout at the right moment, but the sequence looks plausible. Other event sequences might result in the same outcome. To avoid concurrent writes, Squid now drops the control message if Http::One::Server detects that a reply is already being written. Also, ConnStateData delays reply writing until a pending control message write has been completed. This is a Measurement Factory project.	Christos Tsantilas	7 years ago
14944	Bug 4630: user credentials cache cleanup not re-scheduled Bug 4630: user credentials cache cleanup not re-scheduled	Garri Djavadyan	7 years ago
14943	Bug 4599 pt2: use functor for locking in libsecurity Pointer... Bug 4599 pt2: use functor for locking in libsecurity Pointers	Amos Jeffries	7 years ago
14942	Docs: release notes for ICAP Trailers Docs: release notes for ICAP Trailers	Amos Jeffries	7 years ago
14941	ICAP: Initial support for trailers ICAP: Initial support for trailers ICAP trailers are currently specified by https://datatracker.ietf.org/doc/draft-rousskov-icap-trailers/ This implementation complies with version -01 of that draft: - Squid unconditionally announces ICAP Trailer support via the ICAP Allow request header field. - Squid parses the ICAP response trailer if and only if the ICAP server signals its presence by sending both Trailer header and Allow/trailers in the ICAP response. Squid logs and ignores all parsed ICAP header fields (for now). Also refactored HttpHeader parsing methods in order to reuse them for ICAP trailer parsing. Also simplified and fixed headers isolating code while dealing with empty (i.e. zero header fields) headers. Old httpMsgIsolateHeaders() tried to re-implement header end detection/processing logic that is actually covered by headersEnd(). Old httpMsgIsolateHeaders() could return success for some garbage input (e.g., a buffer of several CRs) even if no end of headers was found.	Eduard Bagdasaryan	7 years ago
14940	Bug 3533: Cache still valid after HTTP/1.1 303 See Other Bug 3533: Cache still valid after HTTP/1.1 303 See Other RFC7231 does not mention 303 response as non-cacheable. So, assuming that means it is cacheable.	Garri Djavadyan	7 years ago
14939	SourceFormat Enforcement SourceFormat Enforcement	Source Maintenance	7 years ago
14938	Improve JoinContainerToSBuf Improve JoinContainerToSBuf	Francesco Chemolli	7 years ago
14937	Fix 'ftpSendEPRT defined but not used' compile error after p... Fix 'ftpSendEPRT defined but not used' compile error after patch r14936	Christos Tsantilas	7 years ago
14936	Segfault via Ftp::Client::readControlReply. Segfault via Ftp::Client::readControlReply. Added nil dereference checks for Ftp::Client::ctrl.conn, including: - Ftp::Client::handlePasvReply() and handleEpsvReply() that dereference ctrl.conn in DBG_IMPORTANT messages. - Many functions inside FtpClient.cc and FtpGateway.cc files. TODO: We need to find a better way to handle nil ctrl.conn. It is only a matter of time when we forget to add another dereference check or discover a place we missed during this change. Also disabled forwarding of EPRT and PORT commands to origin servers. Squid support for those commands is broken and their forwarding may cause segfaults (bug #4004). Active FTP is still supported, of course. This is a Measurement Factory project	Christos Tsantilas	7 years ago
14935	Fix some missing returns after rev.14934 Fix some missing returns after rev.14934	Amos Jeffries	7 years ago
14934	Bug 3379: Combination of If-Match and a Cache Hit result in ... Bug 3379: Combination of If-Match and a Cache Hit result in TCP Connection Failure	Garri Djavadyan	7 years ago
14933	Docs: add Release Notes template for Squid-5 Docs: add Release Notes template for Squid-5	Amos Jeffries	7 years ago
14932	Branch 5.0.0 Branch 5.0.0	Source Maintenance	7 years ago

Older »