← Back to branch summary

~ubuntu-security/ubuntu-cve-tracker/master

« back to all changes in this revision

Viewing changes to mir_reviews/trust-store/audits/code-c.txt

  • Committer: Steve Beattie
  • Date: 2019-02-19 06:18:27 UTC
  • Revision ID: sbeattie@ubuntu.com-20190219061827-oh57fzcfc1u9dlfk
The ubuntu-cve-tracker project has been converted to git.

Please use 'git clone https://git.launchpad.net/ubuntu-cve-tracker' to
get the converted tree.

Show diffs side-by-side

added added

removed removed

Lines of Context:
mir_reviews/trust-store/audits/code-c.txt
1
 
Running: /home/sarnold/bin/audit-code.sh -c C ./
2
 
Scanning './'
3
 
== subprocess_spawned() ==
4
 
 
5
 
== memory_management() ==
6
 
./src/core/trust/impl/sqlite3/store.cpp:155:        auto memory = (char*)::malloc(s.size());
7
 
./src/core/trust/impl/sqlite3/store.cpp:156:        ::memcpy(memory, s.c_str(), s.size());
8
 
 
9
 
== files() ==
10
 
./src/core/trust/impl/sqlite3/store.cpp:256:        auto result = sqlite3_open(fn.c_str(), &db);
11
 
 
12
 
== logging() ==
13
 
./src/core/trust/impl/sqlite3/store.cpp:66:std::pair<int, bool> is_error(int result)
14
 
./src/core/trust/impl/sqlite3/store.cpp:133:        std::tie(result, error) = is_error(sqlite3_bind_null(statement, index));
15
 
./src/core/trust/impl/sqlite3/store.cpp:136:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
16
 
./src/core/trust/impl/sqlite3/store.cpp:143:        std::tie(result, error) = is_error(sqlite3_bind_double(statement, index, d));
17
 
./src/core/trust/impl/sqlite3/store.cpp:146:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
18
 
./src/core/trust/impl/sqlite3/store.cpp:161:        std::tie(result, error) = is_error(sqlite3_bind_text(statement, index, memory, s.size(), deleter));
19
 
./src/core/trust/impl/sqlite3/store.cpp:164:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
20
 
./src/core/trust/impl/sqlite3/store.cpp:171:        std::tie(result, error) = is_error(sqlite3_bind_int(statement, index, i));
21
 
./src/core/trust/impl/sqlite3/store.cpp:174:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
22
 
./src/core/trust/impl/sqlite3/store.cpp:181:        std::tie(result, error) = is_error(sqlite3_bind_int64(statement, index, i));
23
 
./src/core/trust/impl/sqlite3/store.cpp:184:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
24
 
./src/core/trust/impl/sqlite3/store.cpp:209:        std::tie(result, error) = is_error(sqlite3_reset(statement));
25
 
./src/core/trust/impl/sqlite3/store.cpp:212:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
26
 
./src/core/trust/impl/sqlite3/store.cpp:218:        std::tie(result, error) = is_error(sqlite3_clear_bindings(statement));
27
 
./src/core/trust/impl/sqlite3/store.cpp:221:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
28
 
./src/core/trust/impl/sqlite3/store.cpp:227:        std::tie(result, error) = is_error(sqlite3_step (statement));
29
 
./src/core/trust/impl/sqlite3/store.cpp:230:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error_from_db());
30
 
./src/core/trust/impl/sqlite3/store.cpp:243:            throw std::runtime_error("Cannot construct prepared statement for null statement.");
31
 
./src/core/trust/impl/sqlite3/store.cpp:261:            throw std::runtime_error(ss.str());
32
 
./src/core/trust/impl/sqlite3/store.cpp:282:        std::tie(result, e) = is_error(
33
 
./src/core/trust/impl/sqlite3/store.cpp:291:            throw std::runtime_error(sqlite3_errstr(result) + std::string(": ") + error());
34
 
./src/core/trust/impl/sqlite3/store.cpp:296:    std::string error() const
35
 
./src/core/trust/impl/sqlite3/store.cpp:298:        auto msg = sqlite3_errmsg(db);
36
 
./src/core/trust/impl/sqlite3/store.cpp:308:    return db->error();
37
 
./src/core/trust/impl/sqlite3/store.cpp:580:                throw std::runtime_error("Cannot delete request as query points beyond the result set.");
38
 
./src/core/trust/impl/sqlite3/store.cpp:617:            throw std::runtime_error("Oops ... we should never reach here.");
39
 
./src/core/trust/impl/sqlite3/store.cpp:644:    const char* error() const;
40
 
./src/core/trust/expose.cpp:123:            auto error = dbus::Message::make_error(
41
 
./src/core/trust/expose.cpp:143:            auto error = core::dbus::Message::make_error(
42
 
./src/core/trust/expose.cpp:182:                    auto error = core::dbus::Message::make_error(
43
 
./src/core/trust/expose.cpp:261:            auto error = core::dbus::Message::make_error(
44
 
./src/core/trust/resolve.cpp:100:            if (result.is_error())
45
 
./src/core/trust/resolve.cpp:112:            if (result.is_error())
46
 
./src/core/trust/resolve.cpp:113:                throw std::runtime_error(result.error().print());
47
 
./src/core/trust/resolve.cpp:120:            if (result.is_error())
48
 
./src/core/trust/resolve.cpp:121:                throw std::runtime_error(result.error().print());
49
 
./src/core/trust/resolve.cpp:128:            if (result.is_error())
50
 
./src/core/trust/resolve.cpp:129:                throw std::runtime_error(result.error().print());
51
 
./src/core/trust/resolve.cpp:136:            if (result.is_error())
52
 
./src/core/trust/resolve.cpp:137:                throw std::runtime_error(result.error().print());
53
 
./src/core/trust/resolve.cpp:144:            if (result.is_error())
54
 
./src/core/trust/resolve.cpp:145:                throw std::runtime_error(result.error().print());
55
 
./src/core/trust/resolve.cpp:157:            if (result.is_error())
56
 
./src/core/trust/resolve.cpp:158:                throw std::runtime_error(result.error().print());
57
 
./src/core/trust/resolve.cpp:165:            if (result.is_error())
58
 
./src/core/trust/resolve.cpp:166:                throw std::runtime_error(result.error().print());
59
 
./src/core/trust/resolve.cpp:175:            if (result.is_error())
60
 
./src/core/trust/resolve.cpp:176:                throw std::runtime_error(result.error().print());
61
 
./src/core/trust/resolve.cpp:189:        if (response.is_error())
62
 
./src/core/trust/resolve.cpp:190:            throw std::runtime_error(response.error().print());
63
 
./src/core/trust/resolve.cpp:202:            if (response.is_error())
64
 
./src/core/trust/resolve.cpp:204:                throw std::runtime_error(response.error().print());
65
 
./src/core/trust/resolve.cpp:218:        if (result.is_error())
66
 
./src/core/trust/resolve.cpp:219:            throw std::runtime_error(result.error().print());
67
 
./include/core/trust/store.h:49:                : std::runtime_error(implementation_specific)
68
 
./include/core/trust/store.h:60:                : std::runtime_error(implementation_specific)
69
 
./include/core/trust/store.h:81:                QueryIsInErrorState() : std::runtime_error("Query is in error state, cannot extract result.")
70
 
./include/core/trust/store.h:91:                NoCurrentResult() : std::runtime_error("Query does not have a current result.")
71
 
./include/core/trust/store.h:178:        ServiceNameMustNotBeEmpty() : std::runtime_error("Service name must not be empty")
72
 
 
73
 
== environment() ==
74
 
./src/core/trust/impl/sqlite3/store.cpp:35:    return std::string{::getenv("HOME")};
75
 
./src/core/trust/impl/sqlite3/store.cpp:40:    char* value = ::getenv("XDG_DATA_HOME");
76
 
 
77
 
== privileged() ==
78
 
 
79
 
== networking() ==
80
 
./src/core/trust/expose.cpp:100:        worker = std::move(std::thread([this](){access_bus()->run();}));
81
 
./tests/remote_trust_store_test.cpp:62:        trap->signal_raised().connect([trap](core::posix::Signal)
82
 
./tests/remote_trust_store_test.cpp:114:        trap->signal_raised().connect([trap](core::posix::Signal)
83
 
./tests/remote_trust_store_test.cpp:186:        trap->signal_raised().connect([trap](core::posix::Signal)
84
 
./tests/remote_trust_store_test.cpp:255:        trap->signal_raised().connect([trap](core::posix::Signal)
85
 
./tests/remote_trust_store_test.cpp:323:        trap->signal_raised().connect([trap](core::posix::Signal)
86
 
./tests/remote_trust_store_test.cpp:391:        trap->signal_raised().connect([trap](core::posix::Signal)
87
 
./tests/remote_trust_store_test.cpp:472:        trap->signal_raised().connect([trap](core::posix::Signal)
88
 
./tests/remote_trust_store_test.cpp:553:        trap->signal_raised().connect([trap](core::posix::Signal)
89
 
./tests/remote_trust_store_test.cpp:639:        trap->signal_raised().connect([trap](core::posix::Signal)
90
 
 
91
 
== http:// ==
92
 
./src/core/trust/codec.h:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
93
 
./src/core/trust/dbus_interface.h:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
94
 
./src/core/trust/request.cpp:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
95
 
./src/core/trust/impl/sqlite3/store.cpp:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
96
 
./src/core/trust/expose.cpp:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
97
 
./src/core/trust/resolve.cpp:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
98
 
./tests/remote_trust_store_test.cpp:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
99
 
./tests/trust_store_test.cpp:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
100
 
./include/core/trust/resolve.h:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
101
 
./include/core/trust/request.h:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
102
 
./include/core/trust/expose.h:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
103
 
./include/core/trust/store.h:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
104
 
./include/core/trust/visibility.h:14: * along with this program.  If not, see <http://www.gnu.org/licenses/>.
105
 
 
106
 
== encryption ==
107
 
 
108
 
== sql() ==
109
 
./src/core/trust/impl/sqlite3/store.cpp:546:        void execute()
110
 
./src/core/trust/impl/sqlite3/store.cpp:651:    std::shared_ptr<core::trust::Store::Query> query();
111
 
./src/core/trust/impl/sqlite3/store.cpp:714:std::shared_ptr<trust::Store::Query> sqlite::Store::query()
112
 
./src/core/trust/expose.cpp:92:            handle_add_query(msg);
113
 
./src/core/trust/expose.cpp:97:            handle_remove_query(msg);
114
 
./src/core/trust/expose.cpp:155:    void handle_add_query(const core::dbus::Message::Ptr& msg)
115
 
./src/core/trust/expose.cpp:162:            auto query = store->query();
116
 
./src/core/trust/expose.cpp:199:                query->execute();
117
 
./src/core/trust/expose.cpp:270:    void handle_remove_query(const core::dbus::Message::Ptr& msg)
118
 
./src/core/trust/resolve.cpp:116:        void execute()
119
 
./src/core/trust/resolve.cpp:212:    std::shared_ptr<core::trust::Store::Query> query()
120
 
./tests/remote_trust_store_test.cpp:158:        auto query = store->query();
121
 
./tests/remote_trust_store_test.cpp:159:        query->execute();
122
 
./tests/remote_trust_store_test.cpp:236:        auto query = store->query();
123
 
./tests/remote_trust_store_test.cpp:238:        query->execute();
124
 
./tests/remote_trust_store_test.cpp:304:        auto query = store->query();
125
 
./tests/remote_trust_store_test.cpp:306:        query->execute();
126
 
./tests/remote_trust_store_test.cpp:372:        auto query = store->query();
127
 
./tests/remote_trust_store_test.cpp:374:        query->execute();
128
 
./tests/remote_trust_store_test.cpp:449:        auto query = store->query();
129
 
./tests/remote_trust_store_test.cpp:453:        query->execute();
130
 
./tests/remote_trust_store_test.cpp:530:        auto query = store->query();
131
 
./tests/remote_trust_store_test.cpp:535:        query->execute();
132
 
./tests/remote_trust_store_test.cpp:614:        auto query = store->query();
133
 
./tests/remote_trust_store_test.cpp:616:        query->execute();
134
 
./tests/remote_trust_store_test.cpp:682:            auto query = store->query();
135
 
./tests/remote_trust_store_test.cpp:683:            query->execute();
136
 
./tests/remote_trust_store_test.cpp:692:        auto query = store->query();
137
 
./tests/remote_trust_store_test.cpp:693:        query->execute();
138
 
./tests/trust_store_test.cpp:69:    auto query = store->query();
139
 
./tests/trust_store_test.cpp:75:    EXPECT_NO_THROW(query->execute());
140
 
./tests/trust_store_test.cpp:107:    auto query = store->query();
141
 
./tests/trust_store_test.cpp:110:    query->execute();
142
 
./tests/trust_store_test.cpp:147:    auto query = store->query();
143
 
./tests/trust_store_test.cpp:149:    query->execute();
144
 
./tests/trust_store_test.cpp:181:    auto query = store->query();
145
 
./tests/trust_store_test.cpp:183:    query->execute();
146
 
./tests/trust_store_test.cpp:215:    auto query = store->query();
147
 
./tests/trust_store_test.cpp:217:    query->execute();
148
 
./tests/trust_store_test.cpp:258:    auto query = store->query();
149
 
./tests/trust_store_test.cpp:262:    query->execute();
150
 
./tests/trust_store_test.cpp:305:    auto query = store->query();
151
 
./tests/trust_store_test.cpp:310:    query->execute();
152
 
./tests/trust_store_test.cpp:350:    auto query = store->query();
153
 
./tests/trust_store_test.cpp:352:    query->execute();
154
 
./tests/trust_store_test.cpp:385:        auto query = store->query();
155
 
./tests/trust_store_test.cpp:386:        query->execute();
156
 
./tests/trust_store_test.cpp:395:    auto query = store->query();
157
 
./tests/trust_store_test.cpp:396:    query->execute();
158
 
./include/core/trust/store.h:128:        virtual void execute() = 0;
159
 
./include/core/trust/store.h:162:    virtual std::shared_ptr<Query> query() = 0;
160
 
 
161
 
== tmp() ==
162
 
 
163
 
== priv_cmds (sudo, gksu, pkexec) ==
164
 
 
165
 
== envvars() ==
166
 
 
167
 
== webkit() ==
168
 
 
169
 
== comments (XXX, FIXME, TODO) ==
170
 
 
171
 
== unsafe input mechanisms ==
172