1206
|
|
|
Albert Astals |
|
9 years ago
|
|
|
1205
|
|
|
Albert Astals |
|
9 years ago
|
|
|
1204
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1203
|
|
|
CI bot |
8.00+14.10.20140825.3-0ubuntu1 |
9 years ago
|
|
|
1202
|
|
|
Michał Sawicz |
|
9 years ago
|
|
|
1201
|
|
|
Daniel d'Andrada |
|
9 years ago
|
|
|
1200
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1199
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1198
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1197
|
|
|
CI bot |
8.00+14.10.20140822-0ubuntu1 |
9 years ago
|
|
|
1196
|
|
|
Mirco Müller |
|
9 years ago
|
|
|
1195
|
|
|
Albert Astals |
|
9 years ago
|
|
|
1194
|
|
|
Gerry Boland |
|
9 years ago
|
|
|
1193
|
|
|
Michael Zanetti |
|
9 years ago
|
|
|
1192
|
|
Allow logging into a desktop or tablet session again, by properly dismissing old PAM conversations. (LP: #1350878)
In a desktop or tablet, we were accidentally starting two PAM conversations in sequence on startup. Which is a small bug; it shouldn't normally be a problem, since each new PAM conversation should kill the old one.
But the way we were killing the old one was subject to a thread race condition. See, a PAM conversation thread won't exit until all its prompts are answered. And what we do when we kill a PAM conversation is to answer all prompts with empty strings.
But it's possible that when we want to kill a PAM conversation that it hasn't actually gotten to the point of prompting us yet. And when those prompts do come through, we were treating them as prompts for the new PAM conversation.
So I've changed the PAM conversation logic to include a pam_handle and compare the handle with the current handle when being prompted. If it's an old handle, we just dismiss the prompt with an empty string response.
Oh, and I fixed the bug that caused two prompts on startup in the first place. (But we still need the above logic anyway, for when you switch users quickly.) Fixes: 1350878 Approved by: Michał Sawicz, Stephen M. Webb, PS Jenkins bot
|
Michael Terry |
|
9 years ago
|
|
|
1191
|
|
|
Michael Terry |
|
9 years ago
|
|
|
1190
|
|
|
Michael Terry |
|
9 years ago
|
|
|
1189
|
|
|
Diego Sarmentero |
|
9 years ago
|
|
|
1188
|
|
|
Martin Pitt |
|
9 years ago
|
|
|
1187
|
|
|
Albert Astals |
|
9 years ago
|
|
|