~akopytov/percona-xtrabackup/bug1169169-2.0

  • Committer: Alexey Kopytov
  • Date: 2013-04-20 16:24:22 UTC
  • Revision ID: akopytov@gmail.com-20130420162422-wpjctmt6zq2tvk1m
Bug #1169169: xtrabackup_56 crashes when preparing a backup with
              partitioned tables

The problem was that xtrabackup_56 used the implementation of
innobase_convert_identifier() provided by the InnoDB code, rather than a
lightweight replacement provided in xtrabackup.cc for other build
flavors. The full-blown implementation may call explain_filename() which
requires MySQL localization subsystem to be initialized (which is
normally initialized in init_common_variables() on server startup). In
particular, it crashed when explain_filename() was called on a
partitioned table.

Since xtrabackup_56 links with ha_innodb.cc containing the full-blown
implementation of innobase_convert_identifier(), the bug was fixed by
replicating the lightweight version used by xtrabackup/xtrabackup_55 in
innodb56.patch.

An alternative approach would be to mimic localization subsystem
initialization performed in mysqld.cc, but that pulls way too many
dependencies.

This revision also fixes bug #1170340 "require_partitioning in
test/inc/ib_part.sh does not work with 5.6" (which was the reason why
bug #1169169 have not been caught by the test suite).
Filename Latest Rev Last Changed Committer Comment Size
..
contrib 241.3.1 13 years ago Daniël van Eeden Add contrib directory with an backup script exampl Diff
doc 213.3.1 13 years ago Aleksandr Kuzminsky Added XtraBackup manual page Diff
patches 228.1.2 13 years ago Alexey Kopytov Port XtraBackup to Percona Server 5.5.9-beta20.1 c Diff
src 385.1.1 12 years ago Alexey Kopytov Rebase of the parallel compression patch on new tr Diff
test 134.1.1 13 years ago Aleksandr Kuzminsky Added the XtraBackup test framework Diff
utils 30.1.2 15 years ago Vadim Tkachenko directory restructure Diff
.bzrignore 449 11 years ago Stewart Smith merge from 1.6: Bug #1021954: XtraBackup on MultiI 196 bytes Diff Download File
BUILD-WIN.txt 244.4.1 13 years ago Alexey Kopytov Added initial support for Windows builds: - remov 2.9 KB Diff Download File
BUILD.txt 504.10.2 11 years ago Laurynas Biveinis Add MySQL 5.6 support. https://blueprints.launchpa 2.3 KB Diff Download File
CMakeLists.txt 244.4.1 13 years ago Alexey Kopytov Added initial support for Windows builds: - remov 1.6 KB Diff Download File
COPYING 174.1.1 13 years ago Stewart Smith add COPYING file with GPLv2 license. xtrabackup is 18.6 KB Diff Download File
File innobackupex 532.1.1 11 years ago Alexey Kopytov Implementation of https://blueprints.launchpad.net 107 KB Diff Download File
VERSION 519.1.1 11 years ago Ignacio Nin Update version to 2.0.6 25 bytes Diff Download File